Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix net-wrap-js-stream-passthrough #25273

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Dec 29, 2018

The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

馃憤 here to fast-track. This fixes node-daily-master Jenkins job. (The benchmark tests are only run there.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
benchmark: fix net-wrap-js-stream-passthrough
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

@Trott Trott added the fast-track label Dec 29, 2018

@lpinca
lpinca approved these changes Dec 29, 2018
@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2018

Benchmark tests aren't run in CI so Lite CI seems sufficient (as it will lint the change at least).

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2018

Landed in 903630e

@Trott Trott closed this Dec 29, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 29, 2018
benchmark: fix net-wrap-js-stream-passthrough
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: nodejs#25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Jan 1, 2019
benchmark: fix net-wrap-js-stream-passthrough
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
benchmark: fix net-wrap-js-stream-passthrough
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: nodejs#25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 17, 2019
benchmark: fix net-wrap-js-stream-passthrough
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 28, 2019
benchmark: fix net-wrap-js-stream-passthrough
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
benchmark: fix net-wrap-js-stream-passthrough
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
benchmark: fix net-wrap-js-stream-passthrough
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.