Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary test flags #25277

Merged
merged 1 commit into from Jan 1, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Dec 29, 2018

This commit removes unnecessary flags used when starting tests via the "// Flags:" directive.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@@ -1,4 +1,3 @@
// Flags: --pending-deprecation --no-warnings

This comment has been minimized.

Copy link
@Trott

Trott Dec 30, 2018

Member

Should the same flags in test-buffer-of-no-deprecation be removed?

This comment has been minimized.

Copy link
@cjihrig

cjihrig Dec 31, 2018

Author Contributor

Yes, thank you.

@lpinca
lpinca approved these changes Dec 30, 2018

@cjihrig cjihrig force-pushed the cjihrig:extra-flags branch from 8e69dd3 to 4c84d06 Dec 31, 2018

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Dec 31, 2018

@Trott Trott added the author ready label Dec 31, 2018

test: remove unnecessary test flags
This commit removes unnecessary flags used when starting
tests via the "// Flags:" directive.

PR-URL: #25277
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:extra-flags branch from 4c84d06 to e765847 Jan 1, 2019

@cjihrig cjihrig merged commit e765847 into nodejs:master Jan 1, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:extra-flags branch Jan 1, 2019

addaleax added a commit that referenced this pull request Jan 5, 2019
test: remove unnecessary test flags
This commit removes unnecessary flags used when starting
tests via the "// Flags:" directive.

PR-URL: #25277
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: remove unnecessary test flags
This commit removes unnecessary flags used when starting
tests via the "// Flags:" directive.

PR-URL: nodejs#25277
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: remove unnecessary test flags
This commit removes unnecessary flags used when starting
tests via the "// Flags:" directive.

PR-URL: nodejs#25277
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.