New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: move DEP0006 to end of life #25279

Merged
merged 1 commit into from Jan 4, 2019

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Dec 30, 2018

This commit moves DEP0006, which has been runtime deprecated since Node 0.11, to end of life status.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@lpinca

lpinca approved these changes Dec 30, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 31, 2018

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Dec 31, 2018

ping @nodejs/tsc. This needs one more sign off.

@ChALkeR

ChALkeR approved these changes Jan 1, 2019

@mcollina
Copy link
Member

mcollina left a comment

LGTM

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Jan 2, 2019

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1706/

I don't really know how to interpret the results, so I'll let @nodejs/citgm weigh in once the job finishes.

lib: move DEP0006 to end of life
This commit moves DEP0006, which has been runtime deprecated
since Node 0.11, to end of life status.

PR-URL: #25279
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

@cjihrig cjihrig force-pushed the cjihrig:customfds branch from bd055a2 to d4934ae Jan 4, 2019

@cjihrig cjihrig merged commit d4934ae into nodejs:master Jan 4, 2019

@cjihrig cjihrig deleted the cjihrig:customfds branch Jan 4, 2019

sam-github added a commit to sam-github/node that referenced this pull request Jan 6, 2019

lib: move DEP0006 to end of life
This commit moves DEP0006, which has been runtime deprecated
since Node 0.11, to end of life status.

PR-URL: nodejs#25279
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

lib: move DEP0006 to end of life
This commit moves DEP0006, which has been runtime deprecated
since Node 0.11, to end of life status.

PR-URL: nodejs#25279
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment