Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove redundant fchmod test #25282

Closed
wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

commented Dec 30, 2018

We test fs.fchmod function in test-fs-fchmod.js, so the test snippet in test-fs-chmod.js is redundant and remove it now.

// Check input type
[false, null, undefined, {}, [], ''].forEach((input) => {
const errObj = {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
message: 'The "fd" argument must be of type number. Received type ' +
typeof input
};
assert.throws(() => fs.fchmod(input), errObj);
assert.throws(() => fs.fchmodSync(input), errObj);
});

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Dec 30, 2018
@danbev

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Landed in ff0f99b 🎉

@addaleax addaleax closed this Jan 7, 2019

addaleax added a commit that referenced this pull request Jan 7, 2019
test: remove redundant fchmod test
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@ZYSzys ZYSzys deleted the zys-contribs:test-fs-remove branch Jan 7, 2019

addaleax added a commit that referenced this pull request Jan 9, 2019
test: remove redundant fchmod test
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: remove redundant fchmod test
PR-URL: nodejs#25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: remove redundant fchmod test
PR-URL: nodejs#25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
test: remove redundant fchmod test
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
test: remove redundant fchmod test
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: remove redundant fchmod test
PR-URL: #25282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.