Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH #25296

Closed
wants to merge 2 commits into from

Conversation

@fshaikh
Copy link
Contributor

commented Dec 31, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] tests and/or benchmarks are included
  • [x ] commit message follows commit guidelines
@antsmartian
Copy link
Contributor

left a comment

LGTM..

(I guess we had the same test case written over this PR: #24014 and it wasn't merged but got closed)

@antsmartian

This comment has been minimized.

Copy link
Contributor

commented Jan 1, 2019

Hello @fshaikh and thanks for your first pull request. I see linter issue, could you please fix the below:

/home/travis/build/nodejs/node/test/parallel/test-http2-origin.js
  73:59  error  Missing semicolon  semi
@lpinca
lpinca approved these changes Jan 1, 2019
@antsmartian

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

@cjihrig
cjihrig approved these changes Jan 2, 2019
@danbev

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Landed in 076d8b9. 🎉

@danbev danbev closed this Jan 7, 2019

danbev added a commit that referenced this pull request Jan 7, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Jan 9, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
PR-URL: nodejs#25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
PR-URL: nodejs#25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
PR-URL: #25296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.