Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: move InternalMakeCallback and MakeCallback into callback_scope.cc #25299

Closed
wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

commented Jan 1, 2019

Since these are just wrappers on top of InternalCallbackScope, this
makes the implementations easier to find.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 1, 2019

hmm, or maybe an alternative solution is to put these in an api.cc ? @addaleax But that may result in another monolithic file as well..

EDIT: or maybe a src/api/ folder would work better?

@devsnek
devsnek approved these changes Jan 1, 2019
@addaleax
Copy link
Member

left a comment

I think it’s fine this way 👍

@jasnell
jasnell approved these changes Jan 1, 2019
@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

This needs a rebase

@addaleax addaleax removed the author ready label Jan 7, 2019

src: move InternalMakeCallback and MakeCallback into callback_scope.cc
Since these are just wrappers on top of `InternalCallbackScope`, this
makes the implementations easier to find.

@joyeecheung joyeecheung force-pushed the joyeecheung:make-callback branch from 500f437 to e301ca8 Jan 8, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

Landed in e54d11e.

@danbev danbev closed this Jan 9, 2019

danbev added a commit that referenced this pull request Jan 9, 2019
src: move InternalMakeCallback and MakeCallback
This commit moves InternalMakeCallback and MakeCallback into
callback_scope.cc. Since these are just wrappers on top of
`InternalCallbackScope`, this makes the implementations easier to find.

#25299
PR-URL: #25299
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 15, 2019
src: move InternalMakeCallback and MakeCallback
This commit moves InternalMakeCallback and MakeCallback into
callback_scope.cc. Since these are just wrappers on top of
`InternalCallbackScope`, this makes the implementations easier to find.

#25299
PR-URL: #25299
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
src: move InternalMakeCallback and MakeCallback
This commit moves InternalMakeCallback and MakeCallback into
callback_scope.cc. Since these are just wrappers on top of
`InternalCallbackScope`, this makes the implementations easier to find.

nodejs#25299
PR-URL: nodejs#25299
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
src: move InternalMakeCallback and MakeCallback
This commit moves InternalMakeCallback and MakeCallback into
callback_scope.cc. Since these are just wrappers on top of
`InternalCallbackScope`, this makes the implementations easier to find.

nodejs#25299
PR-URL: nodejs#25299
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.