Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Remove exec, has been deprecated for years #2530

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@geek
Copy link
Member

commented Aug 24, 2015

@chrisdickinson

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2015

Adding this to the list of things to check.

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2015

LGTM

@geek

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2015

@chrisdickinson do you have a tool that runs a check? If so, can you share the code?

@rvagg rvagg force-pushed the nodejs:master branch from 11c25c2 to ba02bd0 Sep 6, 2015

@targos

This comment has been minimized.

Copy link
Member

commented Oct 9, 2015

@chrisdickinson could you check this one ?

@jasnell

This comment has been minimized.

Copy link
Member

commented Nov 5, 2015

@chrisdickinson ... ping. were you ever able to get around to this?

@jasnell

This comment has been minimized.

Copy link
Member

commented Nov 18, 2015

Putting this on the ctc-agenda tomorrow for a quick sanity check. Don't believe it's controversial at all but worth a double check

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2015

LGTM

1 similar comment
@jasnell

This comment has been minimized.

Copy link
Member

commented Nov 18, 2015

LGTM

geek added a commit that referenced this pull request Nov 18, 2015

util: Remove exec, has been deprecated for years
PR-URL: #2530
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Nov 18, 2015

Landed in 4cf19ad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.