Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix heading in cpp style guide #25303

Closed
wants to merge 1 commit into from

Conversation

@kkty
Copy link
Contributor

commented Jan 1, 2019

Names of c-like structs do not have to end with an underscore.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: fix heading in cpp style guide
Names of c-like structs do not have to end with an underscore.
@danbev
danbev approved these changes Jan 7, 2019
@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Landed in 3255ae4

@addaleax addaleax closed this Jan 7, 2019

addaleax added a commit that referenced this pull request Jan 7, 2019
doc: fix heading in cpp style guide
Names of c-like structs do not have to end with an underscore.

PR-URL: #25303
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax added a commit that referenced this pull request Jan 9, 2019
doc: fix heading in cpp style guide
Names of c-like structs do not have to end with an underscore.

PR-URL: #25303
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
doc: fix heading in cpp style guide
Names of c-like structs do not have to end with an underscore.

PR-URL: nodejs#25303
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: fix heading in cpp style guide
Names of c-like structs do not have to end with an underscore.

PR-URL: nodejs#25303
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
doc: fix heading in cpp style guide
Names of c-like structs do not have to end with an underscore.

PR-URL: #25303
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
doc: fix heading in cpp style guide
Names of c-like structs do not have to end with an underscore.

PR-URL: #25303
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins added a commit that referenced this pull request May 16, 2019
doc: fix heading in cpp style guide
Names of c-like structs do not have to end with an underscore.

PR-URL: #25303
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.