Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: enable transferring WASM modules #25314

Closed
wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

commented Jan 2, 2019

Enable in-memory transfer of WASM modules without recompilation.

Previously, the serialization step worked, but deserialization failed
because we did not explicitly enable decoding inline WASM modules,
and so the message was not successfully received.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax requested a review from devsnek Jan 2, 2019

@devsnek
devsnek approved these changes Jan 2, 2019
addaleax added 2 commits Jan 2, 2019
worker: enable transferring WASM modules
Enable in-memory transfer of WASM modules without recompilation.

Previously, the serialization step worked, but deserialization failed
because we did not explicitly enable decoding inline WASM modules,
and so the message was not successfully received.

@addaleax addaleax force-pushed the addaleax:worker-wasm-transfer branch from 06172bc to 3960521 Jan 4, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

@devsnek In 3960521 I’ve expanded the existing test from #25307 as requested … does this LGTY?

@devsnek

This comment has been minimized.

Copy link
Member

commented Jan 4, 2019

@addaleax seems good

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

@fhinkel
fhinkel approved these changes Jan 5, 2019
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 5, 2019

Landed in 0a549aa

@addaleax addaleax closed this Jan 5, 2019

@addaleax addaleax deleted the addaleax:worker-wasm-transfer branch Jan 5, 2019

Trott pushed a commit to Trott/io.js that referenced this pull request Jan 5, 2019
worker: enable transferring WASM modules
Enable in-memory transfer of WASM modules without recompilation.

Previously, the serialization step worked, but deserialization failed
because we did not explicitly enable decoding inline WASM modules,
and so the message was not successfully received.

PR-URL: nodejs#25314
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax added a commit that referenced this pull request Jan 9, 2019
worker: enable transferring WASM modules
Enable in-memory transfer of WASM modules without recompilation.

Previously, the serialization step worked, but deserialization failed
because we did not explicitly enable decoding inline WASM modules,
and so the message was not successfully received.

PR-URL: #25314
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
worker: enable transferring WASM modules
Enable in-memory transfer of WASM modules without recompilation.

Previously, the serialization step worked, but deserialization failed
because we did not explicitly enable decoding inline WASM modules,
and so the message was not successfully received.

PR-URL: nodejs#25314
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
worker: enable transferring WASM modules
Enable in-memory transfer of WASM modules without recompilation.

Previously, the serialization step worked, but deserialization failed
because we did not explicitly enable decoding inline WASM modules,
and so the message was not successfully received.

PR-URL: nodejs#25314
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.