Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add NAPI_VERSION_EXPERIMENTAL #25319

Closed
wants to merge 2 commits into from

Conversation

@mhdawson
Copy link
Member

commented Jan 2, 2019

Refs: nodejs/node-addon-api#421

Define NAPI_VERSION_EXPERIMENTAL so that it can be
used to guard code in addons that need to check
if a function they want to use is available.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: add NAPI_VERSION_EXPERIMENTAL
Refs: nodejs/node-addon-api#421

Define NAPI_VERSION_EXPERIMENTAL so that it can be
used to guard code in addons that need to check
if a function they want to use is available.
@jasnell
jasnell approved these changes Jan 3, 2019
@@ -5,10 +5,11 @@
#include <stdbool.h>
#include "js_native_api_types.h"

#define NAPI_VERSION_EXPERIMENTAL 2147483647
#ifndef NAPI_VERSION
#ifdef NAPI_EXPERIMENTAL
// Use INT_MAX, this should only be consumed by the pre-processor anyway.

This comment has been minimized.

Copy link
@lpinca

lpinca Jan 3, 2019

Member

Should this comment be also updated/moved?

This comment has been minimized.

Copy link
@mhdawson

mhdawson Jan 3, 2019

Author Member

good point, will update

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2019

@lpinca fixed.

@lpinca
lpinca approved these changes Jan 3, 2019
@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

CI run good, will land once 48 hours is up later today.

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

Landed in 992c8ab

@mhdawson mhdawson closed this Jan 4, 2019

mhdawson added a commit that referenced this pull request Jan 4, 2019
src: add NAPI_VERSION_EXPERIMENTAL
Refs: nodejs/node-addon-api#421

Define NAPI_VERSION_EXPERIMENTAL so that it can be
used to guard code in addons that need to check
if a function they want to use is available.

PR-URL: #25319
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax added a commit that referenced this pull request Jan 5, 2019
src: add NAPI_VERSION_EXPERIMENTAL
Refs: nodejs/node-addon-api#421

Define NAPI_VERSION_EXPERIMENTAL so that it can be
used to guard code in addons that need to check
if a function they want to use is available.

PR-URL: #25319
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
src: add NAPI_VERSION_EXPERIMENTAL
Refs: nodejs/node-addon-api#421

Define NAPI_VERSION_EXPERIMENTAL so that it can be
used to guard code in addons that need to check
if a function they want to use is available.

PR-URL: nodejs#25319
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
src: add NAPI_VERSION_EXPERIMENTAL
Refs: nodejs/node-addon-api#421

Define NAPI_VERSION_EXPERIMENTAL so that it can be
used to guard code in addons that need to check
if a function they want to use is available.

PR-URL: nodejs#25319
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.