Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: split `LoadEnvironment()` at `startExecution()` #25320

Closed
wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

commented Jan 2, 2019

This makes it easier to cater to embedders which wish to skip
the startExecution() part.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
src: split `LoadEnvironment()` at `startExecution()`
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

@addaleax addaleax requested a review from joyeecheung Jan 2, 2019

@joyeecheung
Copy link
Member

left a comment

LGTM. I wonder if as a follow up we should put the JS land startExecution into a separate file..

src/node.cc Outdated Show resolved Hide resolved
if (start_execution.IsEmpty()) return;
start_execution->Call(
env->context(), Undefined(env->isolate()), 0, nullptr);
env->set_start_execution_function(Local<Function>());

This comment has been minimized.

Copy link
@bnoordhuis

bnoordhuis Jan 3, 2019

Member

Maybe do this before the call to, er, Call() as an extra guard against recursive invocation?

This comment has been minimized.

Copy link
@addaleax

addaleax Jan 3, 2019

Author Member

Done, but it requires some extra magic because of the way the env->...() getters work…

@cjihrig
cjihrig approved these changes Jan 3, 2019
@jasnell
jasnell approved these changes Jan 3, 2019
@fhinkel
fhinkel approved these changes Jan 5, 2019
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 5, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2019

Landed in f6a1d88

@addaleax addaleax closed this Jan 6, 2019

@addaleax addaleax deleted the addaleax:embedder-api branch Jan 6, 2019

addaleax added a commit that referenced this pull request Jan 6, 2019
src: split `LoadEnvironment()` at `startExecution()`
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: #25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@kkty kkty referenced this pull request Jan 8, 2019
2 of 2 tasks complete

@BridgeAR BridgeAR added this to Backport requested in v11.x Jan 10, 2019

refack added a commit to refack/node that referenced this pull request Jan 14, 2019
src: split `LoadEnvironment()` at `startExecution()`
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: nodejs#25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
addaleax added a commit that referenced this pull request Jan 15, 2019
src: split `LoadEnvironment()` at `startExecution()`
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: #25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
src: split `LoadEnvironment()` at `startExecution()`
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: nodejs#25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
src: split `LoadEnvironment()` at `startExecution()`
This makes it easier to cater to embedders which wish to skip
the `startExecution()` part.

PR-URL: nodejs#25320
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019

@targos targos removed this from Backport requested in v11.x Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.