New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: remove deprecated crypto._toBuf #25338

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@tniessen
Copy link
Member

tniessen commented Jan 4, 2019

This function has never been documented and was runtime-deprecated in node 11. It is trivial to implement and I cannot find any usage outside of node core.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@cjihrig

cjihrig approved these changes Jan 4, 2019

@lpinca

lpinca approved these changes Jan 4, 2019

@jasnell

jasnell approved these changes Jan 5, 2019

@danbev

This comment has been minimized.

@tniessen

This comment has been minimized.

Copy link
Member

tniessen commented Jan 7, 2019

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 8, 2019

Landed in bf3cb3f

@addaleax addaleax closed this Jan 8, 2019

addaleax added a commit that referenced this pull request Jan 8, 2019

crypto: remove deprecated crypto._toBuf
PR-URL: #25338
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

crypto: remove deprecated crypto._toBuf
PR-URL: nodejs#25338
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment