Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fs.mkdir('/') throws EPERM on Windows #25340

Closed
wants to merge 1 commit into from

Conversation

@coreyfarrell
Copy link
Contributor

commented Jan 4, 2019

Fixes: #25110

Checklist

CC @bcoe @nodejs/fs

@Trott
Copy link
Member

left a comment

Hi, @coreyfarrell! Welcome and thanks for the pull request.

I've left a comment with a requested change. It wraps the text at 80 characters, which you should have received an error about if you ran make lint-md (fast) or make test (slow). It also changes the wording, adds punctuation, and styling. Please take a look.

doc/api/fs.md Outdated Show resolved Hide resolved
@coreyfarrell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2019

@MylesBorins This documentation update is intended for v10.x and v11.x in addition to master.

I assume you don't want me to open PR's for each branch but please let me know if I need to take additional actions or how to handle situations like this in the future.

doc/api/fs.md Outdated Show resolved Hide resolved
@Trott
Trott approved these changes Jan 4, 2019
Copy link
Member

left a comment

LGTM with or without the nit-pick suggestion I just left.

@Trott

This comment has been minimized.

Copy link
Member

commented Jan 4, 2019

I assume you don't want me to open PR's for each branch

Someone will cherry-pick the commit to the other branches. If the cherry-pick does not work because of a conflict, they may leave a comment here asking you to open a backport PR. There's nothing to do at this time, though.

@lpinca
lpinca approved these changes Jan 4, 2019
@bcoe
bcoe approved these changes Jan 4, 2019
Copy link
Member

left a comment

thanks for adding this note @coreyfarrell take or leave my comma preferences.

@@ -2212,6 +2212,15 @@ fs.mkdir('/tmp/a/apple', { recursive: true }, (err) => {
});
```

On Windows, using `fs.mkdir()` on the root directory even with recursion will

This comment has been minimized.

Copy link
@bcoe

bcoe Jan 4, 2019

Member

the nit picky editor in me wonders whether this should be:

Using `fs.mkdir()` on the root directory, even with recursion, will
result in an error on Windows:

This comment has been minimized.

Copy link
@coreyfarrell

coreyfarrell Jan 4, 2019

Author Contributor

My preference is for the fact that it's platform specific to be first but I'm willing to do whatever the consensus is.

This comment has been minimized.

Copy link
@Trott

Trott Jan 4, 2019

Member

This maybe?

On Windows, using `fs.mkdir()` on the root directory, even with recursion, will
result in an error:

@bcoe bcoe added the author ready label Jan 6, 2019

@bcoe

This comment has been minimized.

Copy link
Member

commented Jan 6, 2019

bcoe added a commit that referenced this pull request Jan 6, 2019
doc: fs.mkdir('/') throws EPERM on Windows
Fixes: #25110

PR-URL: #25340
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@bcoe

This comment has been minimized.

Copy link
Member

commented Jan 6, 2019

Landed in e7c6f4f

@bcoe bcoe closed this Jan 6, 2019

@bcoe

This comment has been minimized.

Copy link
Member

commented Jan 6, 2019

@coreyfarrell congrats on your first contribution to Node.js 🎉

@coreyfarrell coreyfarrell deleted the coreyfarrell:fs-mkdir-docs branch Jan 6, 2019

addaleax added a commit that referenced this pull request Jan 9, 2019
doc: fs.mkdir('/') throws EPERM on Windows
Fixes: #25110

PR-URL: #25340
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
doc: fs.mkdir('/') throws EPERM on Windows
Fixes: nodejs#25110

PR-URL: nodejs#25340
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: fs.mkdir('/') throws EPERM on Windows
Fixes: nodejs#25110

PR-URL: nodejs#25340
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
doc: fs.mkdir('/') throws EPERM on Windows
Fixes: #25110

PR-URL: #25340
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
doc: fs.mkdir('/') throws EPERM on Windows
Fixes: #25110

PR-URL: #25340
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
doc: fs.mkdir('/') throws EPERM on Windows
Fixes: #25110

PR-URL: #25340
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.