New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: check curve ID existence instead of asn flags #25345

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@sam-github
Copy link
Member

sam-github commented Jan 4, 2019

Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Fixes: https://github.com/nodejs/node/pull/24358/files#r243099693

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: check curve ID existence instead of asn flags
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Fixes: https://github.com/nodejs/node/pull/24358/files#r243099693
@nornagon
Copy link
Contributor

nornagon left a comment

lgtm, thanks!

@jasnell

jasnell approved these changes Jan 5, 2019

Show resolved Hide resolved src/node_crypto.cc Outdated
Show resolved Hide resolved src/node_crypto.cc Outdated
@sam-github

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 8, 2019

Landed in 4a6ec3b

@addaleax addaleax closed this Jan 8, 2019

addaleax added a commit that referenced this pull request Jan 8, 2019

src: check curve ID existence instead of asn flags
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: #25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

nornagon added a commit to electron/node that referenced this pull request Jan 8, 2019

[cherry-pick] src: check curve ID existence instead of asn flags
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs/node#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

deepak1556 added a commit to electron/node that referenced this pull request Jan 8, 2019

[cherry-pick] src: check curve ID existence instead of asn flags
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs/node#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

addaleax added a commit that referenced this pull request Jan 9, 2019

src: check curve ID existence instead of asn flags
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: #25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@sam-github sam-github deleted the sam-github:simplify-ec-key-info branch Jan 9, 2019

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: check curve ID existence instead of asn flags
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019

Merged

v11.7.0 proposal #25537

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019

src: check curve ID existence instead of asn flags
Simplify the code. The flag check was in the OpenSSL source, but reading
through the docs and source, it is not necessary.

Refs: https://github.com/nodejs/node/pull/24358/files#r243099693
PR-URL: nodejs#25345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment