Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.15.1 proposal #25346

Merged
merged 223 commits into from Jan 29, 2019

Conversation

@codebytere
Copy link
Member

commented Jan 4, 2019

2019-01-29, Version 10.15.1 'Dubnium' (LTS), @codebytere

Notable Changes

  • doc:
    • add oyyd to collaborators (Ouyang Yadong) #24300
  • tls:
    • throw if protocol too long (Andre Jodat-Danbrani) #23606

Commits

  • [fbf5321dcf] - async_hooks: add HandleScopes to C++ embedder/addon API (Anna Henningsen) #24285
  • [0c206e0d6d] - benchmark: support more options in startup benchmark (Joyee Cheung) #24220
  • [9a64ceca39] - buffer: fix writeUInt16BE range check (Brian White) #24208
  • [0b81054d17] - build: fix Python detection when depot_tools are in PATH in Windows (Guy Bedford) #22539
  • [b61a51c4f5] - build: remove sudo:false from .travis.yml (Rich Trott) #24511
  • [5c3736a772] - build: use print() function in configure.py (cclauss) #24484
  • [5d2dadccff] - build: check minimum ICU in configure for system-icu (Steven R. Loomis) #24255
  • [31376d9a97] - build: remove unnecessary prerequisite in Makefile (Rich Trott) #24342
  • [33fd13c5ce] - build: fix benchmark tests on CI (Rich Trott) #24307
  • [07b7db2f81] - build: use BUILDTYPE in bench-addons-build targets (Daniel Bevenius) #24033
  • [4e21eb4004] - build: lint commit message in separate Travis job (Richard Lau) #24254
  • [042749fd23] - build: only try to find node when it's needed by the target (Joyee Cheung) #24115
  • [72d2d2cd8e] - build: expose more openssl categories for addons (Jonathan Cardoso Machado) #23344
  • [dc5647f71b] - build,tools: update make-v8.sh for ppc64le (Refael Ackermann) #24293
  • [5dfc1bb46c] - build,tools: update make-v8.sh for s390x (Refael Ackermann) #23839
  • [04f8d6bffd] - child_process: allow 'http_parser' monkey patching again (Jimb Esser) #24006
  • [3ef68d8d97] - cli: add missing env vars to --help (cjihrig) #24383
  • [4f13ac7941] - console: improve code readability (gengjiawen) #24412
  • [07b9a663e0] - console: cover .assert with single argument (Morgan Roderick) #24188
  • [4749640b2e] - crypto: reduce memory usage of SignFinal (Tobias Nießen) #23427
  • [733cb1ef84] - deps: cherry-pick b87d408 from upstream V8 (Peter Marshall) #24272
  • [17b55bf1a4] - deps: V8: cherry-pick 52a9e67 (Ali Ijaz Sheikh) #25027
  • [185ccedf7c] - doc: clarify who may land on an LTS staging branch (Myles Borins) #24465
  • [3283186934] - doc: revise author ready explanation (Rich Trott) #24558
  • [f918ad8e98] - doc: add readable and writable property to Readable and Writable (Dexter Leng) #23933
  • [d288a395f6] - doc: move trott to tsc emeritus (Rich Trott) #24492
  • [f0602f8df3] - doc: add Ruben Bridgewater to release team (Ruben Bridgewater) #23432
  • [b1bbedd701] - doc: edit COLLABORATOR_GUIDE.md on closing issues (Rich Trott) #24477
  • [08284dcdd8] - doc: move Timothy to TSC emeritus (Timothy Gu) #24535
  • [6bb860cd20] - doc: add NODE_DEBUG_NATIVE to API docs (cjihrig) #24383
  • [ef1056f4bd] - doc: add missing env variables to man page (cjihrig) #24383
  • [40c9ee028b] - doc: minor cleanup of tls.getProtocol() (Sam Roberts) #24533
  • [c16b93233c] - doc: add Beth Griggs to release team (Beth Griggs) #24532
  • [492e2a4d11] - doc: add filehandle.write(string[, position[, encoding]]) (Dara Hayes) #23224
  • [a620c25c76] - doc: udpate list item spacing in changelogs (Rich Trott) #24391
  • [7fd4ef7df1] - doc: update crypto examples to not use deprecated api (Mayank Asthana) #24107
  • [2734c20bd9] - doc: simplify first-time contributors section of Collaborator Guide (Rich Trott) #24387
  • [e11d46cb84] - doc: adjusting formatting when printing (Thomas Hunter II) #24325
  • [c19d6e26a3] - doc: better linkage to node-addon-api (Michael Dawson) #24371
  • [ae3a19486f] - doc: update collaborator guide with LTS labels (Charalampos Fanoulis) #24379
  • [e111d71e60] - doc: document http request.finished boolean (Thomas Watson) #24319
  • [1ca3c9d3e2] - doc: document NODE_TLS_REJECT_UNAUTHORIZED (cjihrig) #24289
  • [68aecff860] - doc: clarify issues and pull requests guidance (Rich Trott) #24316
  • [ac3e264f1c] - doc: fix comma splices in process.md (Rich Trott) #24357
  • [672879f406] - doc: use real protocol names in ALPN example (Sam Roberts) #24232
  • [8a60798f4c] - doc: update core-validate-commit url (Daijiro Wachi) #24331
  • [a9a6cb1b06] - doc: fix echo example programs (Sam Roberts) #24235
  • [90f3f5e88f] - doc: clarify allowed encoding parameter types (Sam Roberts) #24230
  • [4209e122b7] - doc: correct async_hooks resource names (Gerhard Stoebich) #24001
  • [d2cc9d72b6] - doc: sort bottom-of-file markdown links (Sam Roberts) #24679
  • [b4c1d8273c] - doc: update fs.open() changes record for optional 'flags' (Rod Vagg) #24240
  • [cf209171c9] - doc: add links to Stream section (Dmitry Igrishin) #24301
  • [0260db525a] - doc: correct async_hooks sample outputs (Gerhard Stoebich) #24050
  • [c8d2635ed1] - doc: add oyyd to collaborators (Ouyang Yadong) #24300
  • [b305db8634] - doc: edit BUILDING.md (Rich Trott) #24243
  • [abe3edad48] - doc: fix code examples in stream.md (Grant Carthew) #24112
  • [31441f42c4] - doc: describe what tls servername is for (Sam Roberts) #24236
  • [cc688bb23f] - doc: fix some inconsistent use of hostname (Sam Roberts) #24199
  • [6f3bc0d28a] - doc, test: document and test vm timeout escapes (James M Snell) #23743
  • [ef8c1deda6] - doc,meta: update PR approving info (Vse Mozhet Byt) #24561
  • [be56fb7ab9] - events: extract listener check as a function (ZYSzys) #24303
  • [4a16a4da45] - fs: inline typeof check (dexterleng) #24390
  • [35d2397ae5] - http: remove obsolete function escapeHeaderValue (Lauri Piisang) #24173
  • [8df4a168b3] - http2: replace unreachable error with assertion (Rich Trott) #24407
  • [5516fbf1d7] - http2: order declarations in http2.js (ZYSzys) #24411
  • [5e3c6799cb] - http2: elevate v8 namespaces of repeated references (Gagandeep Singh) #24453
  • [4246a40b30] - lib: move encodeStr function to internal for reusable (ZYSzys) #24242
  • [6bd055f7de] - lib: refactor setupInspector in bootstrap/node.js (leeight) #24446
  • [62a5679ca3] - lib: set stderr._destroy to dummyDestroy (Joyee Cheung) #24398
  • [3450a4c536] - lib: gather all errors constant in the same place for consistency (ZYSzys) #24038
  • [5c2c5b9094] - lib: improved conditional check in zlib (Dan Corman) #24190
  • [7527632235] - lib: adjust params from uvExceptionWithHostPort (msmichellegar) #24159
  • [3966b698f6] - lib: combine contructor, tag, Object into a function (Paul Isache) #24171
  • [c84b420457] - Revert "net: partially revert "simplify Socket.prototype._final"" (Anna Henningsen) #24290
  • [0c2d1d57e8] - net: add comments explaining error check (Steven Gabarro) #24222
  • [2d0105c751] - net: remove unreachable check in internalConnect (Philipp Dunkel) #24158
  • [897114bf94] - net: partially revert "simplify Socket.prototype._final" (Anna Henningsen) #24288
  • [10a27277ad] - net: simplify Socket.prototype._final (Anna Henningsen) #24075
  • [b7876ba6e1] - src: elevate namespaces for repeated entities (Sarath Govind K K) #24475
  • [4b82aa80fe] - src: elevate namespaces of repeated artifacts (Maya Anilson) #24429
  • [bfde244576] - src: elevate repeated use of v8 namespaced type (Shubham Urkade) #24427
  • [be14283bcd] - src: use smart pointers in cares_wrap.cc (Daniel Bevenius) #23813
  • [fa52ba621b] - src: elevate v8 namespaces of referenced artifacts (Kanika Singhal) #24424
  • [9a69d030ce] - src: reuse std::make_unique (alyssaq) #24132
  • [44a1993e9d] - src: avoid extra Persistent in DefaultTriggerAsyncIdScope (Anna Henningsen) #23844
  • [15d05bbf02] - src: simplify TimerFunctionCall() in node\_perf.cc (Anna Henningsen) #23782
  • [383d512ed7] - src: memory management using smart pointer (Uttam Pawar) #23628
  • [ffb4087def] - src: remove function hasTextDecoder in encoding.js (Chi-chi Wang) #23625
  • [fa60eb83be] - stream: correctly pause and resume after once('readable') (Matteo Collina) #24366
  • [a7c1d0908a] - stream: do not use crypto.DEFAULT_ENCODING in lazy_transform.js (Joyee Cheung) #24396
  • [965098a8ca] - stream: change comment on duplex stream options (Jesse W. Collins) #24247
  • [6ce4ef3387] - stream: make .destroy() interact better with write queue (Anna Henningsen) #24062
  • [bdab2e98f1] - test: mark test-cli-node-options flaky on arm (Rich Trott) #25032
  • [e5c4759eab] - test: use destructuring on require (Juan José Arboleda) #24455
  • [cb860870cd] - test: fix test case in test-child-process-fork-dgram.js (gengjiawen) #24459
  • [9d7cb1f6d7] - test: replace callback with arrow functions (sreepurnajasti) #24541
  • [a9795f701d] - test: replace callback with arrow function (potham) #24531
  • [088b0db932] - test: replace anonymous function with arrow (Gagandeep Singh) #24527
  • [083925def0] - test: replace anonymous function with arrow (Gagandeep Singh) #24526
  • [95ba7615d1] - test: add information to assertion (Rich Trott) #24566
  • [313eaf958d] - test: replace anonymous function with arrow func (Gagandeep Singh) #24525
  • [1ec6923276] - test: compare objects not identical by reference (Marie Terrier) #24189
  • [6b904f6799] - test: change anonymous closure function to arrow function (Nethra Ravindran) #24433
  • [46e63a2a78] - test: replace closure functions with arrow functions (Gagandeep Singh) #24522
  • [8e6729bb82] - test: replace anonymous function with arrow function (Gagandeep Singh) #24529
  • [54abfda5d3] - test: favor arrow function in callback (Pranay Kothapalli) #24542
  • [d82c0de250] - test: remove unused reject handlers (Dan Foley) #24540
  • [e0a11142b4] - test: refactor test to use arrow functions (sagirk) #24479
  • [7dd64858c2] - test: replace closure with arrow function (Maya Anilson) #24489
  • [d71a607a09] - test: using arrow functions (NoSkillGirl) #24436
  • [5b1fd6e246] - test: replace anonymous closure with arrow func (suman-mitra) #24480
  • [b7b6c12510] - test: replace callback with arrow functions (sreepurnajasti) #24490
  • [e02d553f7b] - test: replcae anonymous closure with arrow function (Sarath Govind K K) #24476
  • [351e69d5c5] - test: refactor test-http-write-empty-string to use arrow functions (sagirk) #24483
  • [d245f53db4] - test: replace anonymous closure with arrow functions (suman-mitra) #24481
  • [8734c679f8] - test: add whatwg-encoding TextDecoder custom inspection with showHidden (ZauberNerd) #24166
  • [7920e7bfb4] - test: replace anonymous closure functions with arrow functions (sagirk) #24478
  • [283a6b86bb] - test: replace anonymous closure functions with arrow function (Abhishek Dixit) #24420
  • [66c3dcab72] - test: replace anonymous closure with arrow funct (Prabu Subra) #24439
  • [e7d41c0312] - test: modify order of parameters for assertion (Mrityunjoy Saha) #24430
  • [164069cdb0] - test: replace closure with arrow functions (kanishk30) #24440
  • [f129e2c063] - test: replace anonymous closure function with arrow function (Kunda Sunil Kumar) #24435
  • [94553b2ea5] - test: add typeerror test for EC crypto keygen (Matteo) #24400
  • [4425926452] - test: change anonymous closure functions to arrow functions (Namit Bhalla) #24418
  • [40773c0f2a] - test: use print() function on both Python 2 and 3 (cclauss) #24485
  • [2ffbde3963] - test: favor arrow functions in callbacks (UjjwalUpadhyay) #24425
  • [8f7326c369] - test: replace anonymous closure functions with arrow function (Amanpreet) #24417
  • [644a9d6919] - test: fix arguments order in napi test_exception (kanishk30) #24413
  • [abe9778ea4] - test: fix the arguments order in assert.strictEqual (Jay Arthanareeswaran) #24416
  • [94d200fe46] - test: replace closure with arrow functions (Amanpreet) #24438
  • [380da0473a] - test: change callback function to arrow function (Jay Arthanareeswaran) #24419
  • [5ad224d6ae] - test: fix the arguments order in assert.strictEqual (apoorvanand) #24431
  • [52259d71d6] - test: assertion equality fix (NoSkillGirl) #24422
  • [2d25cddbc1] - test: remove unused function arguments in async-hooks tests (Simon Bruce) #24406
  • [c29c510b5a] - test: fix actual parameter order for 'assert.strictEqual' (Selvaraj) #24428
  • [bf3bed56db] - test: swap actual&optional params (Nikhil M) #24426
  • [d2d6287355] - test: skip test that use --tls-v1.x flags (Daniel Bevenius) #24376
  • [39a561b3bc] - test: change callback function to arrow function (Lakshmi Shanmugam) #24421
  • [f4c2d9efbc] - test: replace anonymous closure for test-http-expect-handling.js (Jayasankar) #24423
  • [cf7bf27325] - test: replace callback functions with arrow functions (potham) #24432
  • [518bc9679d] - test: use arrow functions for callbacks (Pushkal B) #24444
  • [53973fde9d] - test: replace anonymous closure function (Jayasankar) #24415
  • [555ef65042] - test: fixed the arguments order in assert.strictEqual (Lakshmi Shanmugam) #24414
  • [3b6135ff2c] - test: use destructuring and remove unused arguments (Julia) #24375
  • [8c8199211b] - test: https agent clientcertengine coverage (Osmond van Hemert) #24248
  • [987df276cb] - test: remove unused function arguments in async-hooks tests (Rich Trott) #24368
  • [585db59b0a] - test: add typeerror for vm/compileFunction params (Dan Corman) #24179
  • [6cad1b6877] - test: deep object to table not covered (Osmond van Hemert) #24257
  • [916ead940d] - test: add tests for Socket.setNoDelay (James Herrington) #24250
  • [fbdfd608dd] - test: add process no deprecation (razvanbh) #24196
  • [b29b23546d] - test: fix arguments order in assertions (Emanuel Kluge) #24149
  • [d4fd76a782] - test: remove unused parameters in function definition (Paul Hodgson) #24268
  • [817d871327] - test: esm loader unknown builtin module (Fran Herrero) #24183
  • [8728361533] - test: fixed order of actual and expected arguments (kiyomizumia) #24178
  • [e21d784cf8] - test: add else and error case for TextDecoder (Lauri Piisang) #24162
  • [aba7b47e5c] - test: url format path ending hashchar not covered (Osmond van Hemert) #24259
  • [9970d562c6] - test: test add and remove for lib/domain (Petar Dodev) #24163
  • [51643c208e] - test: fix args order in process-getactiverequests (Vladyslav Kopylash) #24186
  • [454ede2d90] - test: check control characters replacing (Alessandro Gatti) #24182
  • [4d1a80363a] - test: fix v8 Set/Get compiler warnings (Daniel Bevenius) #24246
  • [a30f5a02b8] - test: fix flaky test-vm-timeout-escape-nexttick (Rich Trott) #24251
  • [1bceb9d397] - test: fix test-repl-envvars (Anna Henningsen) #25226
  • [d04c3c2718] - test: move benchmark tests out of main test suite (Rich Trott) #24265
  • [09bb49165f] - test: fix strictEqual argument order (Martin Kask) #24153
  • [704d886000] - test: correct order of args in assert.strictEqual() (Natalie Cluer) #24157
  • [63dc2214f9] - test: add test case for completion bash flag (Aivo Paas) #24168
  • [dd67f39ae2] - test: add test for deepEqual Float32Array (Yehiyam Livneh) #24164
  • [2359273868] - test: fix arguments order in assert.strictEqual() (Ulises Santana Suárez) #24192
  • [3bb63721e3] - test: fix assert.strictEqual argument order (John Mc Quillan) #24172
  • [a6f786dee9] - test: replacing fixture directory with temp (saurabhSiddhu) #24077
  • [704b68aee4] - test: increase coverage internal readline (Berry de Witte) #24150
  • [d8ac55a012] - test: use NULL instead of 0 in common.h (Daniel Bevenius) #24104
  • [4b9518dba3] - test: move test-fs-watch-system-limit from sequential to pummel (Marcus Scott) #23692
  • [4054c24cac] - test: fix uses of deprecated assert.fail with multiple args (ivan.filenko) #23673
  • [c417c7a89a] - test: use assert.strictEqual instead of assert.equal (ivan.filenko) #23673
  • [1b5b1cc08b] - test: add test for strictDeepEqual (Nikita Malyschkin) #24197
  • [cd2dedfa4f] - test: add coverage for systemerror set name (Amer Alimanović) #24200
  • [9fa71468f5] - test: fix order of arguments in assert.strictEqual (Alex Seifert) #24145
  • [2d6e942035] - test: add test for 'ERR_INVALID_CALLBACK' (razvanbh) #24224
  • [540b741ae2] - test: add coverage for escape key switch case (Artur Daschevici) #24194
  • [53b12c3731] - test: fix NewFromUtf8 compiler warning (Daniel Bevenius) #24216
  • [8e9ff69d7f] - test: add error code tests in dgram test (Mark Arranz) #24215
  • [e57a5c3734] - test: fix order of arguments in test-delayed-require assertion (reineke-fox) #24165
  • [d7a3a3bd9f] - test: change arguments order in strictEqual (Paul Isache) #24156
  • [efd697bc57] - test: switch order of strictEqual arguments (Jonah Polack) #24185
  • [9052a22dd1] - test: fix the arguments order in assert.strictEqual (mzucker) #24227
  • [d7722dd9d8] - test: fix the arguments order in assert.strictEqual (mzucker) #24226
  • [2e0d3c9de9] - test: fix order in assert.strictEqual to actual, expected (Kevin Seidel) #24184
  • [b63e9cb3fe] - test: fix arguments order in assert.strictEqual (szabolcsit) #24143
  • [e0c6f5cbf7] - test: fix assert argument order (Manish Poddar) #24160
  • [fc84ccd0f0] - test: removed extraneous argument 's' (Jackson Chui) #24213
  • [90f98905f1] - test: fix arguments order in test-fs-write-buffer (razvanbh) #24155
  • [1588fba73f] - test: fix argument order in assert.strictEqual() (Clement) #24147
  • [f46fa9072a] - test: switch arguments in strictEqual (Mathieu Pavageau) #24141
  • [8f2bdaca69] - test: fix arguments order (Simona Cotin) #24151
  • [380789eb68] - test: fixe argument order in assert.strictEqual (Marc Posth) #24140
  • [cd07b02472] - test: fixing arguments order in assert.strictEqual() (G. Carcaci) #24152
  • [6e8fa5361a] - test: add tests for OutgoingMessage setTimeout (Robin Drexler) #24148
  • [abf9bd15db] - test: swap expected and actual in assert.strictEqual (Florin-Daniel BÎLBÎE) #24146
  • [f0eee63ee0] - test: fix assert parameter order (Roland Broekema) #24144
  • [78a320130d] - test: change order of assert.strictEqual() (Remy Parzinski) #24142
  • [64fd19f102] - test: fix invalid argument order in test-http-expect-continue.js (Morgan Roderick) #24138
  • [2d88af354f] - test: strictEqual argument order (actual, expected) (Ahmad Nassri) #24137
  • [11a84a7b32] - test: swap the order of arguments (Musa Hamwala) #24134
  • [e599889649] - test: fs readfile, swap arguments in strictEqual (Petar Dodev) #24133
  • [c37b3196b6] - test: fix arguments order (Fran Herrero) #24131
  • [74f1dad613] - test: http-client-timeout error assert arguments (Tadhg Creedon) #24130
  • [b16311b19f] - test: mark test-vm-timeout-* known issue tests flaky (James M Snell) #23743
  • [0f6a9524f8] - tls: destroy TLS socket if StreamWrap is destroyed (Anna Henningsen) #24290
  • [0c73221699] - tls: do not rely on 'drain' handlers in StreamWrap (Anna Henningsen) #24290
  • [3170cb49d8] - tls: throw if protocol too long (Andre Jodat-Danbrani) #23606
  • [cc4d866697] - tools: update to remark-lint-preset-node@1.2.0 (Rich Trott) #24391
  • [21843c7659] - tools: fix make lint-md-rollup and run it (Daijiro Wachi) #24333
  • [e8e93df148] - tools: update remark-lint to v6.0.3 from v6.0.2 (Daijiro Wachi) #24333
  • [2bed68f341] - tools: update remark version to v10 from v8 (Daijiro Wachi) #24333
  • [39ccf1461e] - tools: update ESLint to 5.9.0 (cjihrig) #24280
  • [a1d7ed7de6] - tracing: fix static destruction order issue (Anna Henningsen) #24123
  • [8c107a37f9] - url: make the context non-enumerable (Joyee Cheung) #24218
  • [eeb4715a56] - util: remove unreachable branch (rahulshuklab4u) #24447
  • [7576a518b8] - util: deleted unreachable code from util.inspect (kiyomizumia) #24187
  • [c6a43fa2ef] - zlib: do not leak on destroy (Mathias Buus) #23734
tniessen and others added 30 commits Oct 11, 2018
The fixed-size buffer on the stack is unnecessary and way too large
for most applications. This change removes it and allocates the
required memory directly instead of copying into heap later.

PR-URL: #23427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
also... return TextDecoder directly from factories

PR-URL: #23625
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #23734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Those categories are necessary to build addons that depends
 on libcurl and libssh, the following were the missing symbols:
libcurl:
OCSP_cert_status_str
OCSP_check_validity
OCSP_basic_verify
OCSP_RESPONSE_free
OCSP_single_get0_status
OCSP_response_get1_basic
OCSP_BASICRESP_free
OCSP_crl_reason_str
OCSP_resp_count
OCSP_response_status
OCSP_response_status_str
OCSP_resp_get0
d2i_OCSP_RESPONSE
SSL_CTX_set_next_proto_select_cb

libssh:
EVP_ripemd160
EVP_cast5_cbc

Fixes: #23293

PR-URL: #23344
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The convertProtocols() function now throws a range error when the byte
length of a protocol is too long to fit in a Buffer.

Also added a test case in test/parallel/test-tls-basic-validations.js
to cover this.

PR-URL: #23606
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Introduced use of smart pointers instead of MallocedBuffer to manage
memory allocated in the cares library.

PR-URL: #23628
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Using `process.nextTick()` or `Promise`, it
is possible to escape the `timeout` set when running code with
`vm.runInContext()`, `vm.runInThisContext()`, and
`vm.runInNewContext()`.

This documents the issue and adds two known_issues tests.

Refs: #3020
PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Picking a path according to a boolean is essentially free,
compared to the cost of a function call. Also, remove an
unnecessary `TryCatch`.

PR-URL: #23782
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
These are known issues that can be flaky on certain platforms
because they rely entirely on timing differences.

PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Instead of getting a reference to the main `AliasedBuffer`, which
would always unnecesarily allocate and destroy a `Persistent`
handle, store and use a reference to the owning object.

PR-URL: #23844
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Lazy load _http_common and HTTPParser so that the 'http_parser' binding
can be monkey patched before any internal modules require it. This also
probably improves startup performance minimally for programs that never
require the HTTP stack.

Fixes: #23716
Fixes: creationix/http-parser-js#57

PR-URL: #24006
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Right now `node -p process.versions.openssl` always gets run
in the Makefile even when it's not needed by the target
(e.g. `make clean`, `make test-only`). This patch makes it
a run time call instead of part of the global expansion.

PR-URL: #24115
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
PR-URL: #24133
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24131
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24130
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: #24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
`assert.strictEqual` expects arguments in the following order:

actual, expected[, message]

PR-URL: #24138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24137
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24142
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Switched arguments in assert.strictEqual()

PR-URL: #24144
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24146
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
In the `test/parallel/test-vm-create-and-run-in-context.js`
test the actual and expected arguments in the `assert.strictEqual()`
call on line 32 are in the wrong order and they have to be switched
around.

PR-URL: #24141
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
File: test/parallel/test-http-client-upload-buf.js

PR-URL: #24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
These tests ensure that OutgoingMessage setTimeout method
will call setTimeout on its socket

Co-authored-by: ZauberNerd <zaubernerd@zaubernerd.de>

PR-URL: #24148
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #24147
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
the actual and expected arguments in assert.strictEqual() calls are in
the wrong order. Any literal value should be the second argument while
the first argument should be the value returned by a function/be the
calculated value.

PR-URL: #24151
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #24152
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #24155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
In the test test/parallel/test-http-client-upload.js test the
actual and expected arguments in assert.strictEqual() calls
were in the wrong order. Switched them around so the returned
value by the function is the first argument and the literal
value is the second argument.

PR-URL: #24143
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #24160
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
suman-mitra and others added 18 commits Nov 19, 2018
PR-URL: #24480
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
In `test/parallel/test-cluster-send-deadlock.js`, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to `this`,
`super` or `arguments`. This results in shorter functions.

PR-URL: #24479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24490
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24541
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24459
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #24522
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #24525
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24526
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #24531
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #24529
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24540
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Refs: #22255

PR-URL: #24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@codebytere codebytere force-pushed the v10.15.1-proposal branch from 69bb4d0 to 3867ef0 Jan 29, 2019
@codebytere

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

one more CI for posterity

https://ci.nodejs.org/job/node-test-pull-request/20408/

CITGM looked good, spurious failures in CI due to infra issues

Copy link
Member

left a comment

LGTM pending green CI

codebytere added 2 commits Jan 15, 2019
* doc:
  * add oyyd to collaborators (Ouyang Yadong) [#24300](#24300)
* tls:
  * throw if protocol too long (Andre Jodat-Danbrani) [#23606](#23606)

PR-URL: #25346
PR-URL: #25346
@codebytere codebytere force-pushed the v10.15.1-proposal branch from 3867ef0 to 7840f71 Jan 29, 2019
@codebytere codebytere merged commit 7840f71 into v10.x Jan 29, 2019
0 of 2 checks passed
0 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Started
Details
codebytere added a commit that referenced this pull request Jan 29, 2019
* doc:
  * add oyyd to collaborators (Ouyang Yadong) [#24300](#24300)
* tls:
  * throw if protocol too long (Andre Jodat-Danbrani) [#23606](#23606)

PR-URL: #25346
@codebytere codebytere deleted the v10.15.1-proposal branch Jan 29, 2019
miladfarca pushed a commit to miladfarca/node that referenced this pull request Jan 30, 2019
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.