Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 5.12.0 #25347

Merged
merged 1 commit into from Jan 7, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Jan 4, 2019

Update ESLint to 5.12.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
Trott approved these changes Jan 4, 2019
Copy link
Member

left a comment

Look at that beautiful tiny 37-file diff!

@hiroppy
hiroppy approved these changes Jan 5, 2019
@fhinkel
fhinkel approved these changes Jan 5, 2019

@Trott Trott added the author ready label Jan 5, 2019

tools: update ESLint to 5.12.0
Update ESLint to 5.12.0.

PR-URL: #25347
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:eslint branch from 2a34bbc to ec5884a Jan 7, 2019

@cjihrig cjihrig merged commit ec5884a into nodejs:master Jan 7, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:eslint branch Jan 7, 2019

addaleax added a commit that referenced this pull request Jan 9, 2019
tools: update ESLint to 5.12.0
Update ESLint to 5.12.0.

PR-URL: #25347
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
tools: update ESLint to 5.12.0
Update ESLint to 5.12.0.

PR-URL: nodejs#25347
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
tools: update ESLint to 5.12.0
Update ESLint to 5.12.0.

PR-URL: nodejs#25347
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
tools: update ESLint to 5.12.0
Update ESLint to 5.12.0.

PR-URL: #25347
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
tools: update ESLint to 5.12.0
Update ESLint to 5.12.0.

PR-URL: #25347
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
tools: update ESLint to 5.12.0
Update ESLint to 5.12.0.

PR-URL: #25347
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.