Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make modules.md more accurate #25357

Closed
wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Jan 5, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@cjihrig
cjihrig approved these changes Jan 7, 2019
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

Landed in 27a03b8
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-modules-uni branch Jan 7, 2019

vsemozhetbyt added a commit that referenced this pull request Jan 7, 2019
doc: make modules.md more accurate
PR-URL: #25357
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Jan 9, 2019
doc: make modules.md more accurate
PR-URL: #25357
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
doc: make modules.md more accurate
PR-URL: nodejs#25357
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: make modules.md more accurate
PR-URL: nodejs#25357
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.