Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean up wasm fixtures #25360

Merged
merged 1 commit into from Jan 8, 2019

Conversation

@devsnek
Copy link
Member

commented Jan 6, 2019

This just renames the wasm fixtures and adds some comments to their wat sources.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@devsnek devsnek added test wasm labels Jan 6, 2019

@devsnek devsnek requested a review from addaleax Jan 6, 2019

@devsnek

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2019

@devsnek devsnek added the author ready label Jan 6, 2019

@cjihrig
cjihrig approved these changes Jan 6, 2019
test: clean up wasm fixtures
PR-URL: #25360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@devsnek devsnek force-pushed the devsnek:refactor/test-wasm branch from 3007435 to 0c8dedd Jan 8, 2019

@devsnek

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2019

landed in 0c8dedd

@devsnek devsnek merged commit 0c8dedd into nodejs:master Jan 8, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@devsnek devsnek deleted the devsnek:refactor/test-wasm branch Jan 8, 2019

addaleax added a commit that referenced this pull request Jan 9, 2019
test: clean up wasm fixtures
PR-URL: #25360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: clean up wasm fixtures
PR-URL: nodejs#25360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.