Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: initialize `Environment` members in class definition #25369

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Jan 6, 2019

Initialize primitive members of Environment in the class definition for clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: initialize `Environment` members in class definition
Initialize primitive members of `Environment` in the class definition
for clarity.
@lpinca
lpinca approved these changes Jan 6, 2019
@jasnell
jasnell approved these changes Jan 7, 2019
@danbev

This comment has been minimized.

@cjihrig
cjihrig approved these changes Jan 7, 2019
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2019

Landed in 8d893f2

@addaleax addaleax closed this Jan 8, 2019

@addaleax addaleax deleted the addaleax:init-prim branch Jan 8, 2019

addaleax added a commit that referenced this pull request Jan 8, 2019
src: initialize `Environment` members in class definition
Initialize primitive members of `Environment` in the class definition
for clarity.

PR-URL: #25369
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax added a commit that referenced this pull request Jan 9, 2019
src: initialize `Environment` members in class definition
Initialize primitive members of `Environment` in the class definition
for clarity.

PR-URL: #25369
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
src: initialize `Environment` members in class definition
Initialize primitive members of `Environment` in the class definition
for clarity.

PR-URL: nodejs#25369
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.