Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: clean up `node::Init()` wrt embedder scenarios #25370

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Jan 6, 2019

This makes the STL variant of node::Init() a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src/node.cc Outdated Show resolved Hide resolved

@addaleax addaleax force-pushed the addaleax:embedder-api2 branch from 79f41b1 to 1c7e761 Jan 7, 2019

@bnoordhuis
Copy link
Member

left a comment

LGTM. Maybe add // Doesn't return. comments but that's up to you.

@jasnell
jasnell approved these changes Jan 8, 2019
src: clean up `node::Init()` wrt embedder scenarios
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

@addaleax addaleax force-pushed the addaleax:embedder-api2 branch from 1c7e761 to b52078f Jan 8, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

Landed in eb664c3.

@danbev danbev closed this Jan 11, 2019

danbev added a commit that referenced this pull request Jan 11, 2019
src: clean up `node::Init()` wrt embedder scenarios
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

PR-URL: #25370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit that referenced this pull request Jan 15, 2019
src: clean up `node::Init()` wrt embedder scenarios
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

PR-URL: #25370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
src: clean up `node::Init()` wrt embedder scenarios
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

PR-URL: nodejs#25370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
src: clean up `node::Init()` wrt embedder scenarios
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

PR-URL: nodejs#25370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.