Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix section order in vm.md #25374

Closed
wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Jan 7, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

This PR just places the vm.SourceTextModule class section after the vm.Script class section, restoring the alphabetical order.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@lpinca
lpinca approved these changes Jan 7, 2019
doc: fix section order in vm.md
This PR just places the `vm.SourceTextModule` class section
after the `vm.Script` class section, restoring the alphabetical order.

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-vm-sort branch from bdee0cf to afacfcf Jan 11, 2019

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

Rebased. Diff is a bit messed up this time.
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2239/

@danbev

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Landed in 0e1cf1e.

@danbev danbev closed this Jan 14, 2019

danbev added a commit that referenced this pull request Jan 14, 2019
doc: fix section order in vm.md
This PR just places the `vm.SourceTextModule` class section
after the `vm.Script` class section, restoring the alphabetical order.

PR-URL: #25374
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-vm-sort branch Jan 14, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019
doc: fix section order in vm.md
This PR just places the `vm.SourceTextModule` class section
after the `vm.Script` class section, restoring the alphabetical order.

PR-URL: #25374
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: fix section order in vm.md
This PR just places the `vm.SourceTextModule` class section
after the `vm.Script` class section, restoring the alphabetical order.

PR-URL: nodejs#25374
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.