Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix and refactor test-fs-watch-non-recursive #25386

Closed
wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

commented Jan 8, 2019

test-fs-watch-non-recursive was loading the common/tmpdir module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

The test was duplicating some functionality in the tmpdir module. Use tmpdir module instead.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Trott added 2 commits Jan 8, 2019
test: fix test/pummel/test-fs-watch-non-recursive.js
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.
test: refactor test-fs-watch-non-recursive
The test was duplicating some functionality in the `tmpdir` module.
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2019

pummel tests are not run in CI, so lite CI should be sufficient

@cjihrig
cjihrig approved these changes Jan 8, 2019
@jasnell
jasnell approved these changes Jan 8, 2019

@Trott Trott added the author ready label Jan 8, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

Landed in e18b461...fa5af0d

@Trott Trott closed this Jan 10, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 10, 2019
test: fix test/pummel/test-fs-watch-non-recursive.js
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: nodejs#25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Jan 10, 2019
test: refactor test-fs-watch-non-recursive
The test was duplicating some functionality in the `tmpdir` module.

PR-URL: nodejs#25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
test: fix test/pummel/test-fs-watch-non-recursive.js
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
test: refactor test-fs-watch-non-recursive
The test was duplicating some functionality in the `tmpdir` module.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: fix test/pummel/test-fs-watch-non-recursive.js
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: nodejs#25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: refactor test-fs-watch-non-recursive
The test was duplicating some functionality in the `tmpdir` module.

PR-URL: nodejs#25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
test: fix test/pummel/test-fs-watch-non-recursive.js
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 28, 2019
test: refactor test-fs-watch-non-recursive
The test was duplicating some functionality in the `tmpdir` module.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
test: fix test/pummel/test-fs-watch-non-recursive.js
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs added a commit that referenced this pull request May 10, 2019
test: refactor test-fs-watch-non-recursive
The test was duplicating some functionality in the `tmpdir` module.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: fix test/pummel/test-fs-watch-non-recursive.js
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: refactor test-fs-watch-non-recursive
The test was duplicating some functionality in the `tmpdir` module.

PR-URL: #25386
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.