Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,worker_threads: revise worker_threads.md #25402

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 8, 2019

Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc/api/worker_threads.md Outdated Show resolved Hide resolved
doc/api/worker_threads.md Outdated Show resolved Hide resolved
doc,worker_threads: revise worker_threads.md
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

@Trott Trott force-pushed the Trott:revise-worker-threads-doc branch from a13e303 to 3bd05fb Jan 9, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

Rebased, updated based on nits, force-pushed.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

@Trott Trott added the author ready label Jan 9, 2019

@jasnell
jasnell approved these changes Jan 9, 2019
@eugeneo
eugeneo approved these changes Jan 9, 2019
@lpinca
lpinca approved these changes Jan 9, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

Landed in 1415d57

@Trott Trott closed this Jan 11, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 11, 2019
doc,worker: revise worker_threads.md
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

PR-URL: nodejs#25402
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
doc,worker: revise worker_threads.md
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

PR-URL: #25402
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc,worker: revise worker_threads.md
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

PR-URL: nodejs#25402
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.