New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rework ephemeralkeyinfo to run in parallel #25409

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@sam-github
Copy link
Member

sam-github commented Jan 9, 2019

Remove:

  • use of tls global so tests can run in parallel
  • test counting in favour of common.mustCall()
  • limit of only one cipher suite per ephemeral key type tested

The last change will allow adding TLS 1.3 cipher suites and testing
'ECDH' key info with them.

/cc @nodejs/crypto

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
test: rework ephemeralkeyinfo to run in parallel
Remove:
- use of tls global so tests can run in parallel
- test counting in favour of common.mustCall()
- limit of only one cipher suite per ephemeral key type tested

The last change  will allow adding TLS 1.3 cipher suites and testing
'ECDH' key info with them.
@jasnell

jasnell approved these changes Jan 9, 2019

@sam-github

This comment has been minimized.

Copy link
Member

sam-github commented Jan 9, 2019

ci: https://ci.nodejs.org/job/node-test-commit/24898/

Freebsd had issues with test.parallel/test-gc-http-client-onerror, that test seems unstable on FreeBSD, I've seen it fail before.

resume-ci: https://ci.nodejs.org/job/node-test-commit-freebsd/23294/

@sam-github sam-github referenced this pull request Jan 10, 2019

Open

tls: Add PSK support #23188

4 of 4 tasks complete
@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 14, 2019

Landed in 374bdda.

@danbev danbev closed this Jan 14, 2019

danbev added a commit that referenced this pull request Jan 14, 2019

test: rework ephemeralkeyinfo to run in parallel
Remove:
- use of tls global so tests can run in parallel
- test counting in favour of common.mustCall()
- limit of only one cipher suite per ephemeral key type tested

The last change  will allow adding TLS 1.3 cipher suites and testing
'ECDH' key info with them.

PR-URL: #25409
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

addaleax added a commit that referenced this pull request Jan 14, 2019

test: rework ephemeralkeyinfo to run in parallel
Remove:
- use of tls global so tests can run in parallel
- test counting in favour of common.mustCall()
- limit of only one cipher suite per ephemeral key type tested

The last change  will allow adding TLS 1.3 cipher suites and testing
'ECDH' key info with them.

PR-URL: #25409
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019

Merged

v11.7.0 proposal #25537

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019

test: rework ephemeralkeyinfo to run in parallel
Remove:
- use of tls global so tests can run in parallel
- test counting in favour of common.mustCall()
- limit of only one cipher suite per ephemeral key type tested

The last change  will allow adding TLS 1.3 cipher suites and testing
'ECDH' key info with them.

PR-URL: nodejs#25409
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment