Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document that stream.on('close') was changed in Node 10. #25413

Closed
wants to merge 1 commit into from

Conversation

@mcollina
Copy link
Member

commented Jan 9, 2019

See: #25373
See: #18438

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@mcollina

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

doc/api/stream.md Outdated Show resolved Hide resolved
@jasnell
jasnell approved these changes Jan 9, 2019
sam-github added a commit to sam-github/node that referenced this pull request Jan 9, 2019
doc: wrap and punctuate YAML description text
stream.md was the only YAML in doc/api that was using `>` for line
continuation, and only used it for a few descriptions, most used the
same wrapping style the rest of the documentation does.

Also added punctuation and capitialization to a few description
sentences.

Fixes: nodejs#25413 (comment)
@sam-github sam-github referenced this pull request Jan 9, 2019
3 of 3 tasks complete
@mcollina

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

@sam-github do you prefer this to rebase on top of #25419?

doc/api/stream.md Outdated Show resolved Hide resolved
doc/api/stream.md Outdated Show resolved Hide resolved
@sam-github

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

@mcollina sure, rebase or squash and close my PR, if you wish. If you don't, I'll just rebase #25419 onto master once this lands, and cleanup there. Its nbd either way.

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

No I mean, you land that, and then I amend this one? Or the contrary?

@sam-github

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

Actually, #25419 was fast-tracked so I guess rebasing this one would be the way to go. Sorry, I process github notifications sequentially!

@sam-github

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

And it landed (I'm sure you'll notice).

@sam-github sam-github closed this in c2d8a54 Jan 9, 2019

@mcollina mcollina reopened this Jan 9, 2019

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

Reopening this one because it was closed by github.

@mcollina mcollina force-pushed the mcollina:close-event-stream branch from 93d579b to 401ca19 Jan 10, 2019

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

@sam-github @vsemozhetbyt check it out!

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2019

Landed in 18d3aeb

@mcollina mcollina closed this Jan 12, 2019

@mcollina mcollina deleted the mcollina:close-event-stream branch Jan 12, 2019

mcollina added a commit that referenced this pull request Jan 12, 2019
doc: document that stream.on('close') was changed in Node 10
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
doc: wrap and punctuate YAML description text
stream.md was the only YAML in doc/api that was using `>` for line
continuation, and only used it for a few descriptions, most used the
same wrapping style the rest of the documentation does.

Also added punctuation and capitialization to a few description
sentences.

Fixes: #25413 (comment)

PR-URL: #25419
Fixes: #25413
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
doc: document that stream.on('close') was changed in Node 10
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: wrap and punctuate YAML description text
stream.md was the only YAML in doc/api that was using `>` for line
continuation, and only used it for a few descriptions, most used the
same wrapping style the rest of the documentation does.

Also added punctuation and capitialization to a few description
sentences.

Fixes: nodejs#25413 (comment)

PR-URL: nodejs#25419
Fixes: nodejs#25413
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: document that stream.on('close') was changed in Node 10
See: nodejs#25373
See: nodejs#18438

PR-URL: nodejs#25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
doc: document that stream.on('close') was changed in Node 10
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
doc: document that stream.on('close') was changed in Node 10
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
doc: document that stream.on('close') was changed in Node 10
See: #25373
See: #18438

PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.