Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: `os.networkInterfaces()` example outdated #25417

Closed
wants to merge 1 commit into from

Conversation

@jvelezpo
Copy link
Contributor

commented Jan 9, 2019

The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

Fixes: #25408

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: `os.networkInterfaces()` example outdated
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

Fixes: #25408
@vsemozhetbyt

This comment has been minimized.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

Landed in c380ea1
Thank you!

vsemozhetbyt added a commit that referenced this pull request Jan 11, 2019
doc: update `os.networkInterfaces()` example
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
doc: update `os.networkInterfaces()` example
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: update `os.networkInterfaces()` example
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: nodejs#25417
Fixes: nodejs#25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
doc: update `os.networkInterfaces()` example
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
doc: update `os.networkInterfaces()` example
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
doc: update `os.networkInterfaces()` example
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.