Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary skipIfWorker() #25427

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 10, 2019

test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: remove unnecessary skipIfWorker()
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

@lpinca
lpinca approved these changes Jan 10, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 12, 2019
test: remove unnecessary skipIfWorker()
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: nodejs#25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2019

Landed in 91ef9c4

@Trott Trott closed this Jan 12, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019
test: remove unnecessary skipIfWorker()
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: remove unnecessary skipIfWorker()
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: nodejs#25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
test: remove unnecessary skipIfWorker()
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
test: remove unnecessary skipIfWorker()
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: remove unnecessary skipIfWorker()
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.