Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for fs.lchmod #25439

Closed
wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

commented Jan 11, 2019

Test passed on macOS:

$ uname                                                                                                                           
Darwin
$ python tools/test.py -J --mode=release parallel/test-fs-lchmod 
[00:00|% 100|+   1|-   0]: Done
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Jan 11, 2019
@lpinca
lpinca approved these changes Jan 11, 2019
@lpinca

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@shisama

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Landed in 1c7b5db

@addaleax addaleax closed this Jan 14, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019
test: add test for fs.lchmod
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Jan 14, 2019
test: add test for fs.lchmod
PR-URL: nodejs#25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 15, 2019
test: add test for fs.lchmod
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: add test for fs.lchmod
PR-URL: nodejs#25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@ZYSzys ZYSzys deleted the zys-contribs:test-fs-lchmod branch Jan 18, 2019

@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 29, 2019
test: add test for fs.lchmod
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
test: add test for fs.lchmod
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: add test for fs.lchmod
PR-URL: #25439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.