New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix http.Agent timeout option description #25489

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@lpinca
Copy link
Member

lpinca commented Jan 14, 2019

By default the agent options are passed to net.createConnection()
which sets the timeout on the socket immediately after creating it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: fix http.Agent timeout option description
By default the agent options are passed to `net.createConnection()`
which sets the timeout on the socket immediately after creating it.
@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Jan 14, 2019

@lpinca sadly an error occured when I tried to trigger a build :(

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 28, 2019

Landed in 9dc1176

@addaleax addaleax closed this Jan 28, 2019

pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Jan 28, 2019

doc: fix http.Agent timeout option description
By default the agent options are passed to `net.createConnection()`
which sets the timeout on the socket immediately after creating it.

PR-URL: nodejs#25489
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax added a commit that referenced this pull request Jan 28, 2019

doc: fix http.Agent timeout option description
By default the agent options are passed to `net.createConnection()`
which sets the timeout on the socket immediately after creating it.

PR-URL: #25489
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@lpinca lpinca deleted the lpinca:fix/agent-timeout-option-docs branch Jan 29, 2019

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment