Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve known_issues/test-vm-timeout-escape-queuemicrotask #25503

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 14, 2019

Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use common.platformTimeout() to help, adjust timeout to make sure
queueMicrotasks() has a chance to run, and improve error message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Jan 14, 2019

@Trott sadly an error occured when I tried to trigger a build :(

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2019

CI against master hopefully showing this flaky on ubuntu1604-arm64: https://ci.nodejs.org/job/node-stress-single-test/2132/ - (0/1000 OK)

CI against this PR hopefully showing it reliable on ubuntu1604-arm64: https://ci.nodejs.org/job/node-stress-single-test/2133/

CI (scheduled): https://ci.nodejs.org/job/node-test-pull-request/20126/

@refack
refack approved these changes Jan 14, 2019
@refack

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Seems to be overwhelmingly better. As in pre-PR 0/1000 iterations passed, and post-PR ATM all iterations pass (151/151). Just to make sure, both tests run on test-packetnet-ubuntu1604-arm64-2. In this case I think it makes sense to fast track. Please 👍 if you concur.

@bcoe
bcoe approved these changes Jan 15, 2019
Copy link
Member

left a comment

🎉 thanks, have been wrestling with this trying to get a few branches to pass.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

Unrelated failure in another test on Windows. Re-running just Windows (because still waiting for AIX which hasn't even started yet): https://ci.nodejs.org/job/node-test-commit-windows-fanned/23965/

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20133/

Three failures in a row on Windows for parallel/test-trace-events-fs-sync. Starting to worry about that one....

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

Did a full CI re-run and this time Windows passed: https://ci.nodejs.org/job/node-test-commit/25058/

Re-running FreeBSD (only failure, unrelated): https://ci.nodejs.org/job/node-test-commit-freebsd/23400/

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

FreeBSD re-run was green. Landing...

Landed in 27f6d04

@Trott Trott closed this Jan 15, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 15, 2019
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.

PR-URL: nodejs#25503
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
addaleax added a commit that referenced this pull request Jan 15, 2019
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.

PR-URL: #25503
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.

PR-URL: nodejs#25503
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.

PR-URL: nodejs#25503
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.