Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note regarding pushing release tags #25569

Closed
wants to merge 2 commits into from

Conversation

@MylesBorins
Copy link
Member

commented Jan 18, 2019

Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.

doc: add note regarding pushing release tags
Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.

@MylesBorins MylesBorins requested a review from nodejs/releasers Jan 18, 2019

doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2019

landed in 0d31293

MylesBorins added a commit that referenced this pull request Jan 24, 2019
doc: add note regarding pushing release tags
Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.

PR-URL: #25569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request Jan 24, 2019
doc: add note regarding pushing release tags
Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.

PR-URL: #25569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 29, 2019
doc: add note regarding pushing release tags
Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.

PR-URL: #25569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
doc: add note regarding pushing release tags
Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.

PR-URL: #25569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request May 16, 2019
doc: add note regarding pushing release tags
Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.

PR-URL: #25569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.