New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make compress_json python3 compatible #25582

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@thefourtheye
Copy link
Contributor

thefourtheye commented Jan 19, 2019

This patch replaces a usage of map with list comprehension,
which makes the script Python 3 compatiable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

cc @nodejs/python @cclauss

build: make compress_json python3 compatible
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.
@refack

refack approved these changes Jan 19, 2019

@refack

This comment has been minimized.

Copy link
Member

refack commented Jan 19, 2019

I'm looking at the history, and it seems like this is a node-core only tool. Maybe we can eliminate it.

/CC @nodejs/v8-inspector

@thefourtheye

This comment has been minimized.

Copy link
Contributor Author

thefourtheye commented Jan 20, 2019

@refack Good call. If we can get rid of this, one less file to maintain.

@bnoordhuis

This comment has been minimized.

Copy link
Member

bnoordhuis commented Jan 21, 2019

it seems like this is a node-core only tool. Maybe we can eliminate it.

What is the question? I introduced it to shrink the size of the embedded JSON. Currently it reduces its size from about 140k to 15k.

@addaleax

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 28, 2019

Re-run of failing node-test-commit-linux-containered ✔️

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 28, 2019

Landed in b31b84d.

@danbev danbev closed this Jan 28, 2019

danbev added a commit that referenced this pull request Jan 28, 2019

build: make compress_json python3 compatible
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.

PR-URL: #25582
Reviewed-By: Refael Ackermann <refack@gmail.com>

@thefourtheye thefourtheye deleted the thefourtheye:make-compress-json-python3-compatible branch Jan 28, 2019

addaleax added a commit that referenced this pull request Jan 28, 2019

build: make compress_json python3 compatible
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.

PR-URL: #25582
Reviewed-By: Refael Ackermann <refack@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

targos added a commit that referenced this pull request Jan 30, 2019

2019-01-30, Version 11.9.0 (Current)
Notable changes:

* deps:
  * OpenSSL has been updated to 1.1.1a.
    #25582

PR-URL: #25802

targos added a commit that referenced this pull request Jan 30, 2019

2019-01-30, Version 11.9.0 (Current)
Notable changes:

* deps:
  * OpenSSL has been updated to 1.1.1a, which is API/ABI compatible with
    the previous OpenSSL 1.1.0j. Note that while OpenSSL 1.1.1a supports
    TLS1.3, Node.js still does not.
    #25582

PR-URL: #25802

targos added a commit that referenced this pull request Jan 30, 2019

2019-01-30, Version 11.9.0 (Current)
Notable changes:

* deps:
  * OpenSSL has been updated to 1.1.1a, which is API/ABI compatible with
    the previous OpenSSL 1.1.0j. Note that while OpenSSL 1.1.1a supports
    TLS1.3, Node.js still does not.
    #25582

PR-URL: #25802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment