Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace common.PORT with `0` in https renegotiation test #25599

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 21, 2019

Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: replace common.PORT with `0` in https renegotiation test
Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 21, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

Landed in c33d38b

@Trott Trott closed this Jan 23, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 23, 2019
test: replace common.PORT with `0` in https renegotiation test
Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.

PR-URL: nodejs#25599
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Jan 23, 2019
test: replace common.PORT with `0` in https renegotiation test
Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.

PR-URL: #25599
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 29, 2019
test: replace common.PORT with `0` in https renegotiation test
Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.

PR-URL: #25599
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
test: replace common.PORT with `0` in https renegotiation test
Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.

PR-URL: #25599
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: replace common.PORT with `0` in https renegotiation test
Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.

PR-URL: #25599
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.