Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove potential race condition in https renegotiation test #25601

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 21, 2019

In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is
set by the server and checked by the client, which is a separate process
launched with child_process.spawn(). The boolean is not actually
required by the client and might even be causing a race condition on
some operating systems. Remove it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: remove potential race condition in https renegotiation test
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is
set by the server and checked by the client, which is a separate process
launched with child_process.spawn(). The boolean is not actually
required by the client and might even be causing a race condition on
some operating systems. Remove it.
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 21, 2019

@cjihrig
Copy link
Contributor

left a comment

LGTM if the CI passes.

@@ -77,7 +74,6 @@ function test(next) {
let renegs = 0;

child.stderr.on('data', function(data) {

This comment has been minimized.

Copy link
@addaleax

addaleax Jan 21, 2019

Member

Using .on('data') without any sort of buffering might also be very brittle and something that we should fix…?

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20275/

Will have to update the commit message because it's a bit wonky/wrong, but I'm looking forward to landing this one because stress tests show that it fixes the flaky pummel test! 🎉 Once it lands, we'll have to do the same for test-tls-ci-reneg-attack.js. Will open a PR for that now-ish....

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

Landed in c9208f7

@Trott Trott closed this Jan 23, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 23, 2019
test: remove potential race condition in https renegotiation test
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is
causing a race condition on some operating systems. It is unnecessary.
Remove it.

PR-URL: nodejs#25601
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax added a commit that referenced this pull request Jan 23, 2019
test: remove potential race condition in https renegotiation test
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is
causing a race condition on some operating systems. It is unnecessary.
Remove it.

PR-URL: #25601
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 29, 2019
test: remove potential race condition in https renegotiation test
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is
causing a race condition on some operating systems. It is unnecessary.
Remove it.

PR-URL: #25601
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
test: remove potential race condition in https renegotiation test
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is
causing a race condition on some operating systems. It is unnecessary.
Remove it.

PR-URL: #25601
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: remove potential race condition in https renegotiation test
In test/pummel/test-https-ci-reneg-attack.js, there is a boolean that is
causing a race condition on some operating systems. It is unnecessary.
Remove it.

PR-URL: #25601
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.