New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: simplify inspector initialization in node::Start() #25612

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@joyeecheung
Copy link
Member

joyeecheung commented Jan 21, 2019

Remove the StartInspector and InspectorStarted abstraction
out of v8_platform, and error out early and directly in the
option parser if Node is configured with NODE_USE_V8_PLATFORM and
inspector enabled but the user still tries to use inspector options.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
src: simplify inspector initialization in node::Start()
Remove the `StartInspector` and `InspectorStarted` abstraction
out of `v8_platform`, and error out early and directly in the
option parser if Node is configured with NODE_USE_V8_PLATFORM and
inspector enabled but the user still tries to use inspector options.
@joyeecheung

This comment has been minimized.

Copy link
Member Author

joyeecheung commented Jan 21, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member Author

joyeecheung commented Jan 24, 2019

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 25, 2019

Re-run of failing node-test-commit-linux

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 27, 2019

Landed in e3e4048

@addaleax addaleax closed this Jan 27, 2019

addaleax added a commit that referenced this pull request Jan 27, 2019

src: simplify inspector initialization in node::Start()
Remove the `StartInspector` and `InspectorStarted` abstraction
out of `v8_platform`, and error out early and directly in the
option parser if Node is configured with NODE_USE_V8_PLATFORM and
inspector enabled but the user still tries to use inspector options.

PR-URL: #25612
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

src: simplify inspector initialization in node::Start()
Remove the `StartInspector` and `InspectorStarted` abstraction
out of `v8_platform`, and error out early and directly in the
option parser if Node is configured with NODE_USE_V8_PLATFORM and
inspector enabled but the user still tries to use inspector options.

PR-URL: #25612
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment