New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor policy code for readability #25629

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@addaleax
Copy link
Member

addaleax commented Jan 21, 2019

Simplify a few particularly quirky bits of code, and add
whitespace for readability.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
lib: refactor policy code for readability
Simplify a few particularly quirky bits of code, and add
whitespace for readability.
}
} = require('buffer');

const BufferFrom = require('buffer').Buffer.from;

This comment has been minimized.

@lundibundi

This comment has been minimized.

@devsnek

devsnek Jan 21, 2019

Member

aw i liked this before :(

@antsmartian

This comment has been minimized.

Copy link
Contributor

antsmartian commented Jan 22, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 24, 2019

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 25, 2019

Landed in 0f5c14c.

@danbev danbev closed this Jan 25, 2019

petershin pushed a commit to petershin/node that referenced this pull request Jan 25, 2019

lib: refactor policy code for readability
Simplify a few particularly quirky bits of code, and add
whitespace for readability.

PR-URL: nodejs#25629
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

lib: refactor policy code for readability
Simplify a few particularly quirky bits of code, and add
whitespace for readability.

PR-URL: #25629
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment