New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf_hooks: clean up GC listeners #25647

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@addaleax
Copy link
Member

addaleax commented Jan 22, 2019

Add Environment cleanup hooks to remove GC listeners when the Environment is torn down.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
perf_hooks: clean up GC listeners
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

@addaleax addaleax requested a review from joyeecheung Jan 22, 2019

@addaleax addaleax added the perf_hooks label Jan 22, 2019

@addaleax addaleax referenced this pull request Jan 22, 2019

Closed

src: invoke per-isolate setters earlier #25608

2 of 4 tasks complete
@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 24, 2019

This needs another review (maybe @jasnell)?

CI: https://ci.nodejs.org/job/node-test-pull-request/20301/

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 27, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 27, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 28, 2019

Landed in acc5a86

@addaleax addaleax closed this Jan 28, 2019

@addaleax addaleax deleted the addaleax:perf-env-listeners branch Jan 28, 2019

addaleax added a commit that referenced this pull request Jan 28, 2019

perf_hooks: clean up GC listeners
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: #25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

perf_hooks: clean up GC listeners
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: #25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment