New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove known_issues/test-cluster-bind-privileged-port #25649

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@Trott
Copy link
Member

Trott commented Jan 22, 2019

The test was added to check for a bug in macOS Mojave, but it turns out
the issue is a macOS feature, not a bug.

Refs: #21679 (comment)
Fixes: #21679

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: remove known_issues/test-cluster-bind-privileged-port
The test was added to check for a bug in macOS Mojave, but it turns out
the issue is a macOS feature, not a bug.

Refs: #21679 (comment)
Fixes: #21679
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 22, 2019

@Trott Trott added the author ready label Jan 22, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 24, 2019

Landed in 35f45ba

@Trott Trott closed this Jan 24, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 24, 2019

test: remove known_issues/test-cluster-bind-privileged-port
The test was added to check for a bug in macOS Mojave, but it turns out
the issue is a macOS feature, not a bug.

Refs: nodejs#21679 (comment)
Fixes: nodejs#21679

PR-URL: nodejs#25649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

addaleax added a commit that referenced this pull request Jan 28, 2019

test: remove known_issues/test-cluster-bind-privileged-port
The test was added to check for a bug in macOS Mojave, but it turns out
the issue is a macOS feature, not a bug.

Refs: #21679 (comment)
Fixes: #21679

PR-URL: #25649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment