New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify process.binding() deprecation message #25654

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Trott
Copy link
Member

Trott commented Jan 23, 2019

Keep the process.binding() deprecation message short and direct. In
addition to the usual benefits of doing that, it also means the message
is less likely to line-wrap once we move to a runtime deprecation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: simplify process.binding() deprecation message
Keep the process.binding() deprecation message short and direct. In
addition to the usual benefits of doing that, it also means the message
is less likely to line-wrap once we move to a runtime deprecation.

@Trott Trott added the author ready label Jan 23, 2019

@lpinca

lpinca approved these changes Jan 23, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 25, 2019

Landed in 7d27f0e

@Trott Trott closed this Jan 25, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 25, 2019

doc: simplify process.binding() deprecation message
Keep the process.binding() deprecation message short and direct. In
addition to the usual benefits of doing that, it also means the message
is less likely to line-wrap once we move to a runtime deprecation.

PR-URL: nodejs#25654
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

doc: simplify process.binding() deprecation message
Keep the process.binding() deprecation message short and direct. In
addition to the usual benefits of doing that, it also means the message
is less likely to line-wrap once we move to a runtime deprecation.

PR-URL: #25654
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment