New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rewrite fs {f}utimes test file #25656

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Fishrock123
Copy link
Member

Fishrock123 commented Jan 23, 2019

Previously this test silently swallowed some errors.
Hint: That giant callback stack.

Refactored to use common.mustCall() & assert()s.

Also, this adds a couple of extra error-checking cases.


Ugh I'm sorry about this one. I've been meaning to do it forever. (I tired to get someone else to do it as their first PR and that never panned out.)

Anyways this was originally discovered as part of lionheart/openradar-mirror#19944

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-pull-request/20276/

@Fishrock123

This comment has been minimized.

Copy link
Member Author

Fishrock123 commented Jan 23, 2019

Weird. I can't reset the Ci results without doing a full run but they are actually all green. Linuxone failed from Travis (EADDRINUSE..), the actual one is at https://ci.nodejs.org/job/node-test-commit-linuxone/9582/

EDIT: ok just gona rebuild and hopefully get that ... https://ci.nodejs.org/job/node-test-pull-request/20288/

Edit, again, I guess, why not: https://ci.nodejs.org/job/node-test-pull-request/20308/

Sigh, ok rebased to hopefully work after that test fix: https://ci.nodejs.org/job/node-test-pull-request/20377/

@Fishrock123 Fishrock123 force-pushed the Fishrock123:fix-fs-utimes-test branch from 560b854 to ec2a05b Jan 24, 2019

test: rewrite fs {f}utimes test file
Previously this test silently swallowed some errors.

Refactored to use `common.mustCall()` & `assert()`s.

Also, this adds a couple of extra error-checking cases.

@Fishrock123 Fishrock123 force-pushed the Fishrock123:fix-fs-utimes-test branch from ec2a05b to 7939e48 Jan 28, 2019

@Fishrock123

This comment has been minimized.

Copy link
Member Author

Fishrock123 commented Jan 28, 2019

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 28, 2019

Maybe @nodejs/fs as well?

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 28, 2019

Landed in 148cac2

@addaleax addaleax closed this Jan 28, 2019

addaleax added a commit that referenced this pull request Jan 28, 2019

test: rewrite fs {f}utimes test file
Previously this test silently swallowed some errors.

Refactored to use `common.mustCall()` & `assert()`s.

Also, this adds a couple of extra error-checking cases.

PR-URL: #25656
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax added a commit that referenced this pull request Jan 28, 2019

test: rewrite fs {f}utimes test file
Previously this test silently swallowed some errors.

Refactored to use `common.mustCall()` & `assert()`s.

Also, this adds a couple of extra error-checking cases.

PR-URL: #25656
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@Fishrock123 Fishrock123 deleted the Fishrock123:fix-fs-utimes-test branch Jan 28, 2019

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment