/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove common.isOSXMojave #25658

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@refack refack

@benjamingr benjamingr

@lpinca lpinca

@cjihrig cjihrig

@JungMinu JungMinu

@devsnek devsnek

@BethGriggs BethGriggs

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
9 participants
@Trott @nodejs-github-bot @refack @benjamingr @lpinca @cjihrig @JungMinu @devsnek @BethGriggs
@Trott
Copy link
Member

Trott commented Jan 23, 2019

common.isOSXMojave was added because it was believed that there was a
bug in macOS Mojave that allowed unprivileged users to bind to
privileged ports. As it turns out, that was a feature not a bug. It is
likely to be in all future versions of macOS. Remove isOSXMojave and
skip appropriate tests based on isOSX.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
test: remove common.isOSXMojave 
common.isOSXMojave was added because it was believed that there was a
bug in macOS Mojave that allowed unprivileged users to bind to
privileged ports. As it turns out, that was a feature not a bug. It is
likely to be in all future versions of macOS. Remove isOSXMojave and
skip appropriate tests based on isOSX.
Loading status checks…
6b7431e
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Jan 23, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Jan 23, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20277/
@refack

refack approved these changes Jan 23, 2019
View changes

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Jan 23, 2019

Is there a reference we can link too?
@cjihrig

cjihrig approved these changes Jan 23, 2019
View changes

Copy link
Contributor

cjihrig left a comment

LGTM, but it looks like it overlaps with #25649.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Jan 23, 2019

Is there a reference we can link too?

Refs: https://news.ycombinator.com/item?id=18302380

@Trott Trott added the author ready label Jan 23, 2019

@BethGriggs

BethGriggs approved these changes Jan 23, 2019
View changes

@benjamingr

benjamingr approved these changes Jan 23, 2019
View changes

@lpinca

lpinca approved these changes Jan 23, 2019
View changes

@devsnek

devsnek approved these changes Jan 23, 2019
View changes

@JungMinu

JungMinu approved these changes Jan 24, 2019
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Jan 25, 2019

Landed in 399ef4f

@Trott Trott closed this Jan 25, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 25, 2019

@Trott
test: remove common.isOSXMojave 
common.isOSXMojave was added because it was believed that there was a
bug in macOS Mojave that allowed unprivileged users to bind to
privileged ports. As it turns out, that was a feature not a bug. It is
likely to be in all future versions of macOS. Remove isOSXMojave and
skip appropriate tests based on isOSX.

Refs: https://news.ycombinator.com/item?id=18302380
PR-URL: nodejs#25658
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
399ef4f

addaleax added a commit that referenced this pull request Jan 28, 2019

@Trott @addaleax
test: remove common.isOSXMojave 
common.isOSXMojave was added because it was believed that there was a
bug in macOS Mojave that allowed unprivileged users to bind to
privileged ports. As it turns out, that was a feature not a bug. It is
likely to be in all future versions of macOS. Remove isOSXMojave and
skip appropriate tests based on isOSX.

Refs: https://news.ycombinator.com/item?id=18302380
PR-URL: #25658
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
1905f8e

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment