New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix keyObject.symmetricSize to be keyObject.symmetricKeySize #25670

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@panva
Copy link
Contributor

panva commented Jan 23, 2019

This PR fixes wrong property in crypto documentation for an API added in 11.6.0

cc @tniessen

k = crypto.createSecretKey(Buffer.from('foo'))
// SecretKeyObject { [Symbol(kKeyType)]: 'secret' }
k.symmetricSize
// undefined
k.symmetricKeySize
// 3
Checklist
@vsemozhetbyt

This comment has been minimized.

@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jan 26, 2019

Landed in 71b00f0
Thank you!

vsemozhetbyt added a commit that referenced this pull request Jan 26, 2019

doc: fix keyObject.symmetricSize to be keyObject.symmetricKeySize
PR-URL: #25670
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

doc: fix keyObject.symmetricSize to be keyObject.symmetricKeySize
PR-URL: #25670
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment