/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: Improved doc for disabling REPL history on Windows #25672

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@Fishrock123 Fishrock123

@antsmartian antsmartian

@cjihrig cjihrig

@richardlau richardlau

@BridgeAR BridgeAR

@vsemozhetbyt vsemozhetbyt

@bzoz bzoz

Assignees
No one assigned
Labels
doc repl windows
Projects
None yet
Milestone
No milestone
9 participants
@ralish @vsemozhetbyt @BridgeAR @antsmartian @Fishrock123 @cjihrig @richardlau @bzoz @nodejs-github-bot
@ralish
Copy link
Contributor

ralish commented Jan 23, 2019 •
edited by BridgeAR

Environment variables with empty values are not permitted on Windows. As
such, to disable persistent REPL history one or more spaces should be
used. Node will trim whitespace from the variable, resulting in a blank
variable at runtime and the desired behaviour.

Fixes: #25661

Checklist

@nodejs-github-bot nodejs-github-bot added doc repl labels Jan 23, 2019

@ralish ralish referenced this pull request Jan 23, 2019

Closed

Unable to disable REPL history on Windows #25661

@Fishrock123

Fishrock123 approved these changes Jan 23, 2019
View changes

@vsemozhetbyt

vsemozhetbyt approved these changes Jan 23, 2019
View changes

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Jan 23, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2364/

@vsemozhetbyt vsemozhetbyt added the windows label Jan 23, 2019

@BridgeAR

BridgeAR approved these changes Jan 23, 2019
View changes

@cjihrig

cjihrig approved these changes Jan 23, 2019
View changes

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Jan 23, 2019

@ralish thanks a lot for improving this!
@richardlau

richardlau approved these changes Jan 23, 2019
View changes

@antsmartian

antsmartian approved these changes Jan 24, 2019
View changes

@bzoz

bzoz approved these changes Jan 24, 2019
View changes

@antsmartian

This comment has been minimized.

Sign in to view
Copy link
Contributor

antsmartian commented Jan 24, 2019 •
edited

@ralish Could you please take care of the below error, in your commit message:

 ✖  0:7  First word after subsystem(s) in title should be lowercase. title-format
@ralish
repl: improved doc for disabling REPL history on Windows 
Environment variables with empty values are not permitted on Windows. As
such, to disable persistent REPL history one or more spaces should be
used. Node will trim whitespace from the variable, resulting in a blank
variable at runtime and the desired behaviour.

Refs: #25661
Loading status checks…
86e54c6
@ralish

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ralish commented Jan 24, 2019

@antsmartian Sure thing, have done so.
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Jan 26, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2396/
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Jan 26, 2019

Landed in 303585e
Thank you!

@vsemozhetbyt vsemozhetbyt closed this Jan 26, 2019

vsemozhetbyt added a commit that referenced this pull request Jan 26, 2019

@ralish @vsemozhetbyt
repl: improve doc for disabling REPL history on Windows 
Environment variables with empty values are not permitted on Windows. As
such, to disable persistent REPL history one or more spaces should be
used. Node will trim whitespace from the variable, resulting in a blank
variable at runtime and the desired behaviour.

PR-URL: #25672
Fixes: #25661
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Loading status checks…
303585e

addaleax added a commit that referenced this pull request Jan 28, 2019

@ralish @addaleax
repl: improve doc for disabling REPL history on Windows 
Environment variables with empty values are not permitted on Windows. As
such, to disable persistent REPL history one or more spaces should be
used. Node will trim whitespace from the variable, resulting in a blank
variable at runtime and the desired behaviour.

PR-URL: #25672
Fixes: #25661
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
ee61ab6

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment