New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove OpenSSL git and travis configuration #25689

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@sam-github
Copy link
Member

sam-github commented Jan 24, 2019

OpenSSL is packaging its git and travis configuration files. Remove
them, Node.js has its own.

This will remove .gitmodules, .gitattributes, .travis.yml, .travis-create-release.sh, .travis-apt-pin.preference from being present in https://github.com/nodejs/node/tree/master/deps/openssl/openssl

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
deps: remove OpenSSL git and travis configuration
OpenSSL is packaging its git and travis configuration files. Remove
them, Node.js has its own.

@sam-github sam-github requested a review from shigeki Jan 24, 2019

@sam-github

This comment has been minimized.

Copy link
Member Author

sam-github commented Jan 24, 2019

@shigeki Perhaps these files do no harm, but it seems strange to have them in our source, and existing Makefile already deleted one of the git files. What do you think?

@sam-github

This comment has been minimized.

Copy link
Member Author

sam-github commented Feb 1, 2019

@danbev @rvagg @MylesBorins @shigeki, you've done openssl upgrades, what do you think? If no one cares, I'll close this, but it seems odd to me to have openssl's .git and .travis files in our deps tree.

/cc @nodejs/crypto

@danbev

danbev approved these changes Feb 2, 2019

@sam-github

This comment has been minimized.

Copy link
Member Author

sam-github commented Feb 4, 2019

Landed in f395a4a

@sam-github sam-github closed this Feb 4, 2019

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Feb 4, 2019

deps: remove OpenSSL git and travis configuration
OpenSSL is packaging its git and travis configuration files. Remove
them, Node.js has its own.

PR-URL: nodejs#25689
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

@sam-github sam-github deleted the sam-github:openssl-upgrade-cleanup branch Feb 5, 2019

addaleax added a commit that referenced this pull request Feb 6, 2019

deps: remove OpenSSL git and travis configuration
OpenSSL is packaging its git and travis configuration files. Remove
them, Node.js has its own.

PR-URL: #25689
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

@targos targos referenced this pull request Feb 14, 2019

Merged

v11.10.0 proposal #26098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment