New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix file extension on ESM interop example file. #25692

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@ewhitebloom
Copy link
Contributor

ewhitebloom commented Jan 25, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@ewhitebloom

This comment has been minimized.

Copy link
Contributor Author

ewhitebloom commented Jan 25, 2019

I could be mistaken, but the example ESM file should have an .mjs extension, no?

@ewhitebloom ewhitebloom force-pushed the ewhitebloom:fix-esm-interop-doc branch from 2b3a2e4 to 779acad Jan 25, 2019

@vsemozhetbyt
Copy link
Member

vsemozhetbyt left a comment

Thank you.

@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jan 25, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt

This comment has been minimized.

@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jan 27, 2019

Landed in 5109e42
Thank you!

vsemozhetbyt added a commit that referenced this pull request Jan 27, 2019

doc: fix file extension on ESM file example
PR-URL: #25692
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

doc: fix file extension on ESM file example
PR-URL: #25692
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment