New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace Google servers with localhost #25694

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@Trott
Copy link
Member

Trott commented Jan 25, 2019

Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: replace Google servers with localhost
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 25, 2019

@targos

targos approved these changes Jan 25, 2019

@mhdawson
Copy link
Member

mhdawson left a comment

LGTM

@XadillaX
Copy link
Member

XadillaX left a comment

LGTM

@lpinca

lpinca approved these changes Jan 26, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 26, 2019

Now that the pesky test-performance issue has been resolved, let's re-run CI:

https://ci.nodejs.org/job/node-test-pull-request/20338/

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 26, 2019

@Trott Trott added the author ready label Jan 26, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 27, 2019

Landed in 6d937c0

@Trott Trott closed this Jan 27, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 27, 2019

test: replace Google servers with localhost
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: nodejs#25664

PR-URL: nodejs#25694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

test: replace Google servers with localhost
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664

PR-URL: #25694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment