New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix sequential/test-performance delay #25695

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@apapirovski
Copy link
Member

apapirovski commented Jan 25, 2019

This should resolve the flakiness on this test on slower systems where the inited time we store in JS can be much later than the nodeTiming one.

Fixes: #23291

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Trott Trott requested review from jasnell and TimothyGu Jan 25, 2019

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 25, 2019

@TimothyGu
Copy link
Member

TimothyGu left a comment

These are some… quite slow machines. But LGTM, if they are confirmed to fix the flakiness to a satisfactory level.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 25, 2019

These are some… quite slow machines.

Indeed a Raspberry Pi can have as little as 256 Mb of RAM and a 700 MHz processor. Not sure if that's the spec for these machines, but it certainly gives you the idea.

@Trott Trott added the author ready label Jan 25, 2019

@Trott

Trott approved these changes Jan 25, 2019

@Trott Trott added the fast-track label Jan 25, 2019

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 25, 2019

Please 👍 here to approve fast-tracking to unbreak CI.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 26, 2019

Landed in d1d357d

@Trott Trott closed this Jan 26, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 26, 2019

test: fix sequential/test-performance delay
PR-URL: nodejs#25695
Fixes: nodejs#23291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

test: fix sequential/test-performance delay
PR-URL: #25695
Fixes: #23291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment