Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
test: remove s_client from test-tls-ci-reneg-attack #25700
Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of
Refs: #25676 (comment)
This test is currently broken (due to a quirk in a recent s_client update that we haven't worked around yet, see Ref above) and this change fixes it. The test is only run once a day in CI (because it's in pummel) so the breakage went unnoticed when the OpenSSL update landed a few days ago. A subsequent PR could probably move this test out of pummel. It seems like it could reasonably run in sequential or maybe even parallel.
Lite CI (because pummel tests are not run in regular CI): https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2397/
node-daily-master custom suite test that runs pummel modified to run against this PR and only run this test (because this is not the only broken pummel test right now): https://ci.nodejs.org/job/node-test-commit-custom-suites/840/