New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix 11.8.0 changelog #25705

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@MylesBorins
Copy link
Member

MylesBorins commented Jan 25, 2019

Problem with tool resulted in wrong commits being included

doc: fix 11.8.0 changelog
Problem with tool resulted in wrong commits being included
@MylesBorins

This comment has been minimized.

Copy link
Member Author

MylesBorins commented Jan 25, 2019

fast track?

@cjihrig
Copy link
Contributor

cjihrig left a comment

Rubberstamp LGTM

@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Jan 25, 2019

@MylesBorins I think all the REPLACEME's that were er, replaced in 641de82 should have been v11.8.0 and not v11.7.0. Do you want to fix them here along with the changelog, or leave for a separate PR?

@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Jan 25, 2019

(and given that I approved #25687 I'll take some of the blame here) 😅

@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Jan 25, 2019

I've raised #25709 to fix the docs metadata. Feel free to either fold it into this PR or process it on its own.

@richardlau richardlau referenced this pull request Jan 25, 2019

Closed

doc: fix metadata for v11.8.0 doc changes #25709

3 of 3 tasks complete
@lpinca

lpinca approved these changes Jan 25, 2019

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 25, 2019

Landed in 96731fc

@addaleax addaleax closed this Jan 25, 2019

addaleax added a commit that referenced this pull request Jan 25, 2019

doc: fix 11.8.0 changelog
Problem with tool resulted in wrong commits being included

PR-URL: #25705
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax added a commit that referenced this pull request Jan 28, 2019

doc: fix 11.8.0 changelog
Problem with tool resulted in wrong commits being included

PR-URL: #25705
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment