New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add metadata to report docs #25708

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@richardlau
Copy link
Member

richardlau commented Jan 25, 2019

Fixes: #25682

I based the metadata based on the other files in doc/ (we don't seem to have much (any?) documentation on what metadata should be included).

cc @nodejs/documentation

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jan 25, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 25, 2019

Landed in f40778e

@addaleax addaleax closed this Jan 25, 2019

addaleax added a commit that referenced this pull request Jan 25, 2019

doc: add metadata to report docs
Fixes: #25682

PR-URL: #25708
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax added a commit that referenced this pull request Jan 28, 2019

doc: add metadata to report docs
Fixes: #25682

PR-URL: #25708
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment